Implement logic to check whether package requires system reboot #587
Assignees
Labels
Priority: MEDIUM
Triaged
Someone on the DNF 5 team has read the issue and determined the next steps to take
Comments
evan-goode
added
Priority: MEDIUM
Triaged
evan-goode
added a commit
to evan-goode/dnf5
that referenced
this issue
Aug 31, 2023
Reboot is suggested for a transaction if any of the involved packages is EITHER (1) part of a hardcoded set of "core" packages (including kernel and systemd) OR (2) has an associated advisory with reboot_suggested=True. For rpm-software-management#587
evan-goode
added a commit
to evan-goode/dnf5
that referenced
this issue
Sep 12, 2023
evan-goode
added a commit
to evan-goode/dnf5
that referenced
this issue
Sep 15, 2023
evan-goode
added a commit
to evan-goode/dnf5
that referenced
this issue
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
DNF 4 has
base.reboot_needed(): boolwhich checks whether a system reboot is recommended following the transaction. In DNF 4, the logic is very crude, this function simply checks the set of packages involved in the transaction against a hardcoded set of "important" packages which includessystemd,kernel, andglibc.In DNF 5, we should investigate better ways to do this check. jmracek proposed using the
<reboot_suggested>True</reboot_suggested>advisory, which I think is the best approach, but has the disadvantage that advisories are mostly only supported by RHEL and Fedora repos. I'm not sure how someone would flag a package in their COPR repository as "needs reboot".Another idea is to examine the files changed in the transaction and use some heuristic to make a decision. Or some combination of these three methods (hardcoded list, advisories, checking files).
This logic will be needed for the DNF 5 needs-restarting plugin (#389) and by the
rebootoption, if we choose to keep it, in whatever replaces DNF automatic (#57).API users may also want to use this functionality, see https://bugzilla.redhat.com/show_bug.cgi?id=2164835.
The text was updated successfully, but these errors were encountered: