Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement machine-readable output for commands #867

Open
2 of 4 tasks
jan-kolarik opened this issue Sep 5, 2023 · 3 comments
Open
2 of 4 tasks

Implement machine-readable output for commands #867

jan-kolarik opened this issue Sep 5, 2023 · 3 comments
Assignees
Labels
Priority: MEDIUM Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take
Milestone

Comments

@jan-kolarik
Copy link
Member

jan-kolarik commented Sep 5, 2023

Based on the #512, the target format for machine-readable output should be json, which is also supported by the libsmartcols library, commonly used for command output in DNF.

For the supported commands, machine-readable output will be requested with the --json option.

Commands to be implemented:

@softwaresale
Copy link
Contributor

It looks like there is a JSON wrapper in copr already. Would it be worth while to either:

  1. Move that wrapper into libdnf5 so that it can be used across the different commands
  2. Create a new wrapper in libdnf5 instead of reusing copr's
  3. Not create a wrapper at all and just use raw json-c

@jan-kolarik
Copy link
Member Author

jan-kolarik commented Dec 15, 2023

It looks like there is a JSON wrapper in copr already. Would it be worth while to either:

  1. Move that wrapper into libdnf5 so that it can be used across the different commands
  2. Create a new wrapper in libdnf5 instead of reusing copr's
  3. Not create a wrapper at all and just use raw json-c

Hi, thanks for the suggestion. I was looking into the copr plugin and there it is really used for processing the JSON input. Here for the machine-readable output we would probably just utilize the libsmartcols functionality to print the output in JSON format and probably do some transformation of the existing scols table into the json scols one. So it looks to me so far that no JSON library would be needed for this use case.

@jan-kolarik jan-kolarik added Priority: MEDIUM Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take labels Jan 2, 2024
@jan-kolarik jan-kolarik self-assigned this Jan 8, 2024
@jan-kolarik
Copy link
Member Author

Following-up on #1072 (comment), I was trying to utilize the libsmartcols API for JSON outputs. Unfortunately, I couldn't find a way to produce nested JSON objects. Even without that, the code became cumbersome when trying to transpose the existing tables for a more natural JSON output.

I'll proceed by attempting to utilize the existing json-c library for this, taking into account the common JSON wrapper in libdnf5, as suggested by @softwaresale if it makes sense. However, the refactoring of the output header files is necessary first. Therefore I'm postponing the work until the related issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: MEDIUM Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take
Projects
Status: In Progress
Development

No branches or pull requests

2 participants