Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock 5.4 writes build log (and possibly other logs) into root log #1302

Open
Korulag opened this issue Feb 2, 2024 · 3 comments
Open

Mock 5.4 writes build log (and possibly other logs) into root log #1302

Korulag opened this issue Feb 2, 2024 · 3 comments
Labels

Comments

@Korulag
Copy link

Korulag commented Feb 2, 2024

Short description of the problem

It appears that mock 5.4 is not closing root log after preparing the environment and continues to write there the whole build process log. It was not the case on 4.1, I didn't check other 5.* versions because updates brought 5.4.

Output of rpm -q mock


mock-5.4-1.el8.noarch

Steps to reproduce issue

  1. Build any package from src.rpm:
    mock --configdir $config_dir --root $root --verbose --rebuild $src.rpm --resultdir $rpm_result --define ... --no-cleanup-after
  2. Check produced root log

On 4.1 the root logs ends like so:

DEBUG util.py:167:  kill orphans
DEBUG util.py:621:  child environment: None

And a bunch of umount comands. On 5.4 it just continues.
Even more, it looks like installed_packages log is also included.

@praiskup
Copy link
Member

Indeed, while build.log contains the output, it is duplicated in root.log. Thank you for the report.

@praiskup praiskup added the bug label Feb 12, 2024
@praiskup
Copy link
Member

The --verbose option seems to trigger this misbehavior.

@Korulag
Copy link
Author

Korulag commented Feb 19, 2024

Yes, we enable verbose output when using mock in some cases. Thanks for investigation @praiskup !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants