Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPEL 10 chroots #1421

Closed
hroncok opened this issue Aug 12, 2024 · 8 comments · Fixed by #1424
Closed

EPEL 10 chroots #1421

hroncok opened this issue Aug 12, 2024 · 8 comments · Fixed by #1424
Assignees

Comments

@hroncok
Copy link
Contributor

hroncok commented Aug 12, 2024

Please add CentOS Stream 10 + EPEL 10 chroot configs. There is no compose yet, just the Koji buildroot.

Thanks.

cc @carlwgeorge

@hroncok
Copy link
Contributor Author

hroncok commented Aug 12, 2024

@carlwgeorge
Copy link
Contributor

I was planning on doing this after we had it published and mirrored, to avoid hitting the koji tag repo to hard. If that's not a concern I can send a PR with the configs, and then another later to switch to the mirror metalinks.

@hroncok
Copy link
Contributor Author

hroncok commented Aug 13, 2024

I already hit the Koji repo manually, making it available in the official mock-core-configs might expose a bit more, but I don't think it will destroy Koji. There's --enable-repo=local and there's Fedora i686 config using Koji only already.

@praiskup praiskup self-assigned this Aug 14, 2024
@praiskup
Copy link
Member

I am going to submit PR today.

praiskup added a commit to praiskup/mock that referenced this issue Aug 14, 2024
These work with Koji EPEL buildroot only for now since there are no
composes, yet.

Fixes: rpm-software-management#1421
@praiskup
Copy link
Member

If that's not a concern I can send a PR with the configs

@carlwgeorge I missed your offer. Sure, if you have it handy! Or perhaps review #1424?

One thing that concerns me is the epel-10.0-build part of baseurl :-( does it mean we'll have to update the baseurl link anytime new minor arrives?

@carlwgeorge
Copy link
Contributor

I'll be happy to review #1424.

For epel-release we're going to use the $releasever_major${releasever_minor:+.$releasever_minor} pattern that was already suggested in that PR. I think the best approach will be to have two epel10 templates, one without the minor version and one with it, sort of like the separate rawhide/branched templates for Fedora. CentOS Stream would use epel-10.tpl without the minor version and wouldn't need to be aware of the minor version at all, since the published repo will be pub/epel/10. RHEL would use epel-10-branched.tpl (I'm open to better file names) with the minor version. This would work best with the RHEL template also integrating the minor versions. We could use config_opts['releasever_major'] = '10' in rhel-10.tpl, and then have files like rhel+epel-10.0-x86_64 that set config_opts['releasever_minor'] = '0'.

As an aside, this visual aid from the EPEL 10 hackfest at Flock may be useful for you in understanding which parts of the pipeline will have the minor version and which ones won't.

@praiskup
Copy link
Member

The centos-stream+epel-10 chroots for now use 10.0 version, per 3802ca3 (therefore this one was closed). But there's #1427 where we may use what you suggest. I'm going to review PRs if you already know which way you prefer.

then have files like rhel+epel-10.0-x86_64

From the Mock's maintainer perspective, we will need your (EPEL team) help here. These minor-based configuration files are known from openSUSE world, and it is very hard to catch up. The set of configuration files will explode, and I'm not very happy about this (the mock-core-configs is used in Fedora Copr, and it would be similar there).

@praiskup praiskup moved this from Needs triage to In Progress in CPT Kanban Aug 16, 2024
@FrostyX FrostyX moved this from In Progress to Done in CPT Kanban Aug 19, 2024
@carlwgeorge
Copy link
Contributor

Both the EPEL Steering Committee and the CPE EPEL team are on board with helping wherever we can. EPEL 10's embracement of minor versions brings many benefits, but we're aware we don't get these for free. There has already been a tremendous amount of work done towards this goal, with plenty more to do.

I'm not married to the fully minor-based configuration files, but if we do go that route we can include steps in the EPEL branching SOP to send the necessary pull requests to handle the changes. I'll comment on #1427 with my thoughts around our options on handling this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants