Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is package_manager.py worth its own exception? #1477

Open
praiskup opened this issue Sep 28, 2024 · 0 comments
Open

Is package_manager.py worth its own exception? #1477

praiskup opened this issue Sep 28, 2024 · 0 comments

Comments

@praiskup
Copy link
Member

We raise Exception and Runtime Exception from package_manager.py file. If this happens, the output of Mock and log files dump the whole stack trace which is probably unnecessary.
@github-project-automation github-project-automation bot moved this to Needs triage in CPT Kanban Sep 28, 2024
praiskup added a commit to praiskup/mock that referenced this issue Sep 28, 2024
@praiskup
package_manager: fix linter issues
9abe5f7 
The rename of methods makes linter thing these are new issues:

- Ignore the f"" warning, as f-string is not optimal for this use-case.
- Use RuntimeError instead of the generic Exception.  It is still too
  generic and mock prints stack trace if it happens, but
  package_manager.py probably deserves it's own exception (rpm-software-management#1477).
praiskup added a commit to praiskup/mock that referenced this issue Sep 28, 2024
@praiskup
package_manager: fix linter issues
99164b6 
The rename of methods makes linter thing these are new issues:

- Ignore the f"" warning, as f-string is not optimal for this use-case.
- Use RuntimeError instead of the generic Exception.  It is still too
  generic and mock prints stack trace if it happens, but
  package_manager.py probably deserves it's own exception (rpm-software-management#1477).
praiskup added a commit to praiskup/mock that referenced this issue Sep 30, 2024
@praiskup
package_manager: fix linter issues
34cc381 
The rename of methods makes linter thing these are new issues:

- Ignore the f"" warning, as f-string is not optimal for this use-case.
- Use RuntimeError instead of the generic Exception.  It is still too
  generic and mock prints stack trace if it happens, but
  package_manager.py probably deserves it's own exception (rpm-software-management#1477).
praiskup added a commit to praiskup/mock that referenced this issue Sep 30, 2024
@praiskup
package_manager: fix linter issues
1fed15e 
The rename of methods makes linter thing these are new issues:

- Ignore the f"" warning, as f-string is not optimal for this use-case.
- Use RuntimeError instead of the generic Exception.  It is still too
  generic and mock prints stack trace if it happens, but
  package_manager.py probably deserves it's own exception (rpm-software-management#1477).
xsuchy pushed a commit that referenced this issue Sep 30, 2024
@praiskup @xsuchy
package_manager: fix linter issues
516144a 
The rename of methods makes linter thing these are new issues:

- Ignore the f"" warning, as f-string is not optimal for this use-case.
- Use RuntimeError instead of the generic Exception.  It is still too
  generic and mock prints stack trace if it happens, but
  package_manager.py probably deserves it's own exception (#1477).
@nikromen nikromen moved this from Needs triage to Someday in future in CPT Kanban Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@praiskup