Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limiting height of <ul> also limits height of vertical line #29

Open
tomrobst opened this issue May 20, 2016 · 3 comments
Open

Limiting height of <ul> also limits height of vertical line #29

tomrobst opened this issue May 20, 2016 · 3 comments

Comments

@tomrobst
Copy link

Hi,

Great library, very easy to use, thank you!

I'm trying to limit the height of the timeline on the page by setting the height and overflow: auto properties of the

    under the tag. This works apart from the vertical line separating the left and right side (and where the badges are display) is also set to the height of the
      so once you start scrolling the vertical line doesn't continue. Any suggestions?

      Thanks,

      Tom

@tomrobst
Copy link
Author

Sorry github turned my tags into actual html tags...

It should say I'm trying to limit the height by setting the height and overflow CSS properties on the <ul> tag under the <timeline> tag but the vertical line is set to the height of the <ul> tag!

@rpocklin
Copy link
Owner

rpocklin commented Jun 7, 2016

A plunkr would be invaluable here.

@tomrobst
Copy link
Author

tomrobst commented Jun 7, 2016

Ok, I agree and I'll try and set one up shortly. In the meantime I see that the line is created as a pseudo-element in the timeline CSS. I was trying to come up with a method to set the height of this pseudo-element once the scrollHeight property of the <ul> has been set (after the timeline array has been created). It would be easier if this was a real element instead of a :before css pseudo-element...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants