Timeout on enqueue not working

[WillNye]

I did see #49 but since it is almost 2 years old I figured I'd create a new one.
I attempted setting a timeout with the following:

my_scheduler = Scheduler('my_task', connection=Redis())

my_scheduler.enqueue(
a_param,
another_param,
**{'timeout': 2700}
)

While this doesn't fail out it still defaults to 3 minutes.

I've tracked down what I believe to be the issue.

enqueue_in calls _create_job and passes in any kwargs.
_create_job then calls create.
create does not use kwargs to get the timeout, it defines it within the function arguments.

enqueue_in either needs to have a timeout argument or this should be in _create_job

try:
timeout = kwargs['timeout']
except KeyError:
timeout = None

I created a fork which features this at https://github.com/SiSTeRTech/rq-scheduler if you'd like to merge

[lechup]

I think _create_job should have timeout kwarg, and we should get rid of:

        if timeout is not None:
            job.timeout = timeout

From Scheduler.cron() and other places, just pass it to _create_job.

@selwin is there any reason it's not implemented like that?

[selwin]

scheduler.schedule already accepts timeout argument, so it would make sense that scheduler.enqueue_in and scheduler.enqueue_at also accept timeout argument.

@lechup I agree with your suggestion, _create_job should accept a timeout argument. PR for this is welcome :).

[lechup]

@selwin I've created #124 , @WillNye maybe You can base on it?

[lechup]

@WillNye I've checked Your fork, and it contains more than this change (some changes in setup.py). Can You prepare different branch based on my branch I want to merge in #124 and simply include only changes to enqueue_in and enqueue_at?

[djmaze]

Is this problem fixed, as #124 has been merged for a long time now?