Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractAnnotation and JAXBAnnotationGroupedByPatcher broken during modularization #16

Open
rreganjr opened this issue Apr 18, 2018 · 1 comment
Open

AbstractAnnotation and JAXBAnnotationGroupedByPatcher broken during modularization #16

rreganjr opened this issue Apr 18, 2018 · 1 comment
Labels
refactor non-functional code changes tech debt
Milestone
1.0.3

Comments

@rreganjr
Copy link
Owner

While splitting out classes into modules I hit an issue where some annotation classes depend on project classes and vice-versa. I had to comment out some code in AbstractAnnotation and JAXBAnnotationGroupedByPatcher relating to how project xml files are imported and the relationships reconstituted.
rreganjr added a commit that referenced this issue Apr 18, 2018
@rreganjr
https://github.com/rreganjr/Requel/issues/7
bd200ae 
#8
#9
#10
#11
#12
branch 1.0.3

I had to make more modules than originally expected to get around some cyclic dependencies, but there are still some issues, new bugs created. see #16

Signed-off-by: rreganjr <[email protected]>
@rreganjr rreganjr added refactor non-functional code changes tech debt labels Apr 18, 2018
@rreganjr rreganjr added this to the 1.0.3 milestone Apr 18, 2018
@rreganjr
Copy link
Owner Author

AbstractAnnotation was fixed as part of #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor non-functional code changes tech debt
Projects
None yet
Milestone
1.0.3
Development

No branches or pull requests
1 participant
@rreganjr