From fe0097a0fd2714f93192b8ff4bc6a6088406c7a6 Mon Sep 17 00:00:00 2001 From: rrigato Date: Sun, 26 Nov 2023 08:46:45 -0600 Subject: [PATCH 1/3] style setup for book section --- static/css/homepageSection.css | 4 ++++ static/js/BookRecommendations.jsx | 9 +++++++++ static/tests/BookRecommendations.test.js | 5 +++++ 3 files changed, 18 insertions(+) diff --git a/static/css/homepageSection.css b/static/css/homepageSection.css index 7f17e7d..87eaaf0 100644 --- a/static/css/homepageSection.css +++ b/static/css/homepageSection.css @@ -22,6 +22,10 @@ ul{ margin-right: 10px; } +.book-details{ + list-style-position: inside; +} + .homepage-content{ background-color: #aaaaaa; border-radius: 5%; diff --git a/static/js/BookRecommendations.jsx b/static/js/BookRecommendations.jsx index 60ebfcd..a9b8be1 100644 --- a/static/js/BookRecommendations.jsx +++ b/static/js/BookRecommendations.jsx @@ -11,6 +11,15 @@ export function BookRecommendations(){
diff --git a/static/tests/BookRecommendations.test.js b/static/tests/BookRecommendations.test.js index 932ab57..276cd99 100644 --- a/static/tests/BookRecommendations.test.js +++ b/static/tests/BookRecommendations.test.js @@ -13,9 +13,14 @@ describe('BookRecommendations displayed on screen', () => { const {getAllByRole, getByRole} = render(); + const bookLinks = getAllByRole( + 'link' + ); const numHeaders = getAllByRole( 'heading' ); + expect(bookLinks.length).toBe(1); expect(numHeaders.length).toBe(2); + }); }); \ No newline at end of file From a48ba6b2613d4a970040c76c5970a02379ac36df Mon Sep 17 00:00:00 2001 From: rrigato Date: Sun, 26 Nov 2023 09:03:01 -0600 Subject: [PATCH 2/3] Up to 4 book recommendations --- .github/workflows/homepage_update.yml | 1 - static/js/BookRecommendations.jsx | 33 +++++++++++++++++++++--- static/tests/BookRecommendations.test.js | 2 +- 3 files changed, 30 insertions(+), 6 deletions(-) diff --git a/.github/workflows/homepage_update.yml b/.github/workflows/homepage_update.yml index 67165d2..f1172eb 100644 --- a/.github/workflows/homepage_update.yml +++ b/.github/workflows/homepage_update.yml @@ -2,7 +2,6 @@ name: Updates web application on: push: branches: - - dev - master jobs: diff --git a/static/js/BookRecommendations.jsx b/static/js/BookRecommendations.jsx index a9b8be1..23ea42c 100644 --- a/static/js/BookRecommendations.jsx +++ b/static/js/BookRecommendations.jsx @@ -13,14 +13,39 @@ export function BookRecommendations(){

Everyday Reads

  • Incerto by Nassim Taleb -
  • - Five book collection centered around the understanding of randomness in your everyday life. - -
    • +
  • + Five book collection centered around the understanding of randomness in your everyday life. + +
    • +

    Software Engineering

    + +
  • Clean Architecture by + Bob Martin +
    • +
  • + The goal of software architecture is to minimize the human resources required to build and maintain the desired application. +
    • + +
  • Rework by + DHH and Jason Fried +
    • +
  • + Outlines office culture for working remote +
    • + +
  • Shape Up by + Ryan Singer +
    • +
  • + Outside of the fact that he objectively has the coolest first name a human can have, + this is the definitive guide on how iterations should be structured in any devops oriented team. +
    • + diff --git a/static/tests/BookRecommendations.test.js b/static/tests/BookRecommendations.test.js index 276cd99..98e6aba 100644 --- a/static/tests/BookRecommendations.test.js +++ b/static/tests/BookRecommendations.test.js @@ -19,7 +19,7 @@ describe('BookRecommendations displayed on screen', () => { const numHeaders = getAllByRole( 'heading' ); - expect(bookLinks.length).toBe(1); + expect(bookLinks.length).toBe(4); expect(numHeaders.length).toBe(2); }); From 6a3d7341fb718618fd16cdda5499b92f8563b666 Mon Sep 17 00:00:00 2001 From: rrigato Date: Sun, 26 Nov 2023 09:54:40 -0600 Subject: [PATCH 3/3] clean up formatting --- static/js/BookRecommendations.jsx | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/static/js/BookRecommendations.jsx b/static/js/BookRecommendations.jsx index 23ea42c..a2c5fcc 100644 --- a/static/js/BookRecommendations.jsx +++ b/static/js/BookRecommendations.jsx @@ -2,8 +2,8 @@ import React from 'react'; import '../css/homepageSection.css'; /**Book Recommendations - * - * @returns react jsx + * + * @returns react jsx */ export function BookRecommendations(){ return( @@ -16,13 +16,12 @@ export function BookRecommendations(){
  • - Five book collection centered around the understanding of randomness in your everyday life. - + Five book collection centered around the understanding the impacts of randomness.

    • Software Engineering

    - +
  • Clean Architecture by Bob Martin
    • @@ -37,7 +36,7 @@ export function BookRecommendations(){
  • Outlines office culture for working remote
    • - +
  • Shape Up by Ryan Singer