Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show miniatures on the artists page #49

Open
jvoisin opened this issue Apr 11, 2019 · 4 comments
Open

Show miniatures on the artists page #49

jvoisin opened this issue Apr 11, 2019 · 4 comments

Comments

@jvoisin
Copy link

jvoisin commented Apr 11, 2019

No description provided.

@rrrnld
Copy link
Owner

rrrnld commented Apr 11, 2019

Can you explain what you mean with miniatures? Smaller covers?

@jvoisin
Copy link
Author

jvoisin commented Apr 11, 2019

This is what I have in mind, pictures of the artists, instead of an arid text list:

@rrrnld
Copy link
Owner

rrrnld commented Apr 11, 2019

Ah, I assumed you were talking about the artist's detail page, but you are talking about the overview page. I guess that's the drawback of dogfooding: A lot of the artists in my collection do not have images for them on last.fm, which is where airsonic fetches them from. How would you deal with that? Maybe have a button to swap between the views? And when swapping we save which view was activated, so if you prefer one over the other, you only ever see that.

@almet
Copy link

almet commented Nov 6, 2019

How would you deal with that? Maybe have a button to swap between the views? And when swapping we save which view was activated, so if you prefer one over the other, you only ever see that.

That seems to make sense. If no cover exists for the artist, then don't display any. Having a button to swap between views (and remember which one was last selected) seems reasonable :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants