Merge pull request wildfly#18377 from bstansberry/WFLY-19940

[WFLY-19940] Remove MaxMetaspaceSize settings
rsearls · Nov 14, 2024 · ddc6a03 · ddc6a03
2 parents 208e47b + 218e14f
commit ddc6a03
Show file tree

Hide file tree

Showing 15 changed files with 11 additions and 15 deletions.
diff --git a/docs/src/main/asciidoc/Getting_Started_Guide.adoc b/docs/src/main/asciidoc/Getting_Started_Guide.adoc
@@ -430,7 +430,7 @@ to what's shown below.
  
   JAVA: java
  
-  JAVA_OPTS:  -server -Xms64m -Xmx512m -XX:MetaspaceSize=96M -XX:MaxMetaspaceSize=256m -Djava.net.preferIPv4Stack=true -Djboss.modules.system.pkgs=com.yourkit,org.jboss.byteman -Djava.awt.headless=true
+  JAVA_OPTS:  -server -Xms64m -Xmx512m -XX:MetaspaceSize=96M -Djava.net.preferIPv4Stack=true -Djboss.modules.system.pkgs=com.yourkit,org.jboss.byteman -Djava.awt.headless=true
  
 =========================================================================
  

diff --git a/ee-feature-pack/galleon-shared/src/main/resources/content/bin/appclient.conf b/ee-feature-pack/galleon-shared/src/main/resources/content/bin/appclient.conf
@@ -42,7 +42,7 @@ fi
 # Specify options to pass to the Java VM.
 #
 if [ "x$JAVA_OPTS" = "x" ]; then
-   JAVA_OPTS="-Xms64m -Xmx512m -XX:MaxMetaspaceSize=256m -Djava.net.preferIPv4Stack=true"
+   JAVA_OPTS="-Xms64m -Xmx512m -Djava.net.preferIPv4Stack=true"
    JAVA_OPTS="$JAVA_OPTS -Djboss.modules.system.pkgs=$JBOSS_MODULES_SYSTEM_PKGS -Djava.awt.headless=true"
 fi
 

diff --git a/ee-feature-pack/galleon-shared/src/main/resources/content/bin/appclient.conf.bat b/ee-feature-pack/galleon-shared/src/main/resources/content/bin/appclient.conf.bat
@@ -40,7 +40,7 @@ rem # options that are always passed by run.bat.
 rem #
 
 rem # JVM memory allocation pool parameters - modify as appropriate.
-set "JAVA_OPTS=-Xms64M -Xmx512M -XX:MaxMetaspaceSize=256m"
+set "JAVA_OPTS=-Xms64M -Xmx512M"
 
 rem # Prefer IPv4
 set "JAVA_OPTS=%JAVA_OPTS%  -Djava.net.preferIPv4Stack=true "

diff --git a/ee-feature-pack/galleon-shared/src/main/resources/content/bin/appclient.conf.ps1 b/ee-feature-pack/galleon-shared/src/main/resources/content/bin/appclient.conf.ps1
@@ -41,7 +41,6 @@ $JAVA_OPTS = @()
 # JVM memory allocation pool parameters - modify as appropriate.
 $JAVA_OPTS += '-Xms64M'
 $JAVA_OPTS += '-Xmx512M'
-$JAVA_OPTS += '-XX:MaxMetaspaceSize=256m'
 
 # Reduce the RMI GCs to once per hour for Sun JVMs.
 $JAVA_OPTS += '-Dsun.rmi.dgc.client.gcInterval=3600000'

diff --git a/ee-feature-pack/galleon-shared/src/main/resources/feature_groups/host-primary.xml b/ee-feature-pack/galleon-shared/src/main/resources/feature_groups/host-primary.xml
@@ -10,7 +10,7 @@
         <param name="host" value="primary"/>
         <feature spec="host.jvm">
             <param name="jvm" value="default"/>
-            <param name="jvm-options" value="[&quot;-server&quot;,&quot;-XX:MetaspaceSize=96m&quot;,&quot;-XX:MaxMetaspaceSize=256m&quot;]"/>
+            <param name="jvm-options" value="[&quot;-server&quot;,&quot;-XX:MetaspaceSize=96m&quot;]"/>
         </feature>
     </feature>
 </feature-group-spec>
diff --git a/ee-feature-pack/galleon-shared/src/main/resources/feature_groups/host-secondary.xml b/ee-feature-pack/galleon-shared/src/main/resources/feature_groups/host-secondary.xml
@@ -13,7 +13,7 @@
         <param name="host" value="secondary"/>
         <feature spec="host.jvm">
             <param name="jvm" value="default"/>
-            <param name="jvm-options" value="[&quot;-server&quot;,&quot;-XX:MetaspaceSize=96m&quot;,&quot;-XX:MaxMetaspaceSize=256m&quot;]"/>
+            <param name="jvm-options" value="[&quot;-server&quot;,&quot;-XX:MetaspaceSize=96m&quot;]"/>
         </feature>
     </feature>
 </feature-group-spec>
diff --git a/ee-feature-pack/galleon-shared/src/main/resources/feature_groups/host.xml b/ee-feature-pack/galleon-shared/src/main/resources/feature_groups/host.xml
@@ -13,7 +13,7 @@
         <param name="host" value="primary"/>
         <feature spec="host.jvm">
             <param name="jvm" value="default"/>
-            <param name="jvm-options" value="[&quot;-server&quot;,&quot;-XX:MetaspaceSize=96m&quot;,&quot;-XX:MaxMetaspaceSize=256m&quot;]"/>
+            <param name="jvm-options" value="[&quot;-server&quot;,&quot;-XX:MetaspaceSize=96m&quot;]"/>
         </feature>
         <feature spec="host.server-config">
             <param name="server-config" value="server-two"/>

diff --git a/ee-feature-pack/galleon-shared/src/main/resources/feature_groups/servlet-host-primary.xml b/ee-feature-pack/galleon-shared/src/main/resources/feature_groups/servlet-host-primary.xml
@@ -26,7 +26,7 @@
             <param name="jvm" value="default"/>
             <param name="heap-size" value="64m"/>
             <param name="max-heap-size" value="256m"/>
-            <param name="jvm-options" value="[&quot;-server&quot;,&quot;-XX:MetaspaceSize=96m&quot;,&quot;-XX:MaxMetaspaceSize=256m&quot;]"/>
+            <param name="jvm-options" value="[&quot;-server&quot;,&quot;-XX:MetaspaceSize=96m&quot;]"/>
             <unset param="environment-variables"/>
         </feature>
     </feature>

diff --git a/ee-feature-pack/galleon-shared/src/main/resources/feature_groups/servlet-host-secondary.xml b/ee-feature-pack/galleon-shared/src/main/resources/feature_groups/servlet-host-secondary.xml
@@ -14,7 +14,7 @@
                 <param name="jvm" value="default"/>
                 <param name="heap-size" value="64m"/>
                 <param name="max-heap-size" value="256m"/>
-                <param name="jvm-options" value="[&quot;-server&quot;,&quot;-XX:MetaspaceSize=96m&quot;,&quot;-XX:MaxMetaspaceSize=256m&quot;]"/>
+                <param name="jvm-options" value="[&quot;-server&quot;,&quot;-XX:MetaspaceSize=96m&quot;]"/>
                 <unset param="environment-variables"/>
             </feature>
         </include>

diff --git a/ee-feature-pack/galleon-shared/src/main/resources/feature_groups/servlet-host.xml b/ee-feature-pack/galleon-shared/src/main/resources/feature_groups/servlet-host.xml
@@ -16,7 +16,7 @@
         </feature>
         <feature spec="host.jvm">
             <param name="jvm" value="default"/>
-            <param name="jvm-options" value="[&quot;-server&quot;,&quot;-XX:MetaspaceSize=96m&quot;,&quot;-XX:MaxMetaspaceSize=256m&quot;]"/>
+            <param name="jvm-options" value="[&quot;-server&quot;,&quot;-XX:MetaspaceSize=96m&quot;]"/>
         </feature>
         <feature spec="host.server-config">
             <param name="server-config" value="server-two"/>

diff --git a/pom.xml b/pom.xml
@@ -245,7 +245,7 @@
         <!-- Surefire args -->
         <surefire.extra.args></surefire.extra.args>
         <surefire.jpda.args></surefire.jpda.args>
-        <surefire.non-modular.system.args>-ea -Duser.region=US -Duser.language=en -XX:MaxMetaspaceSize=1024m ${surefire.jpda.args} ${surefire.extra.args} ${surefire.jacoco.args}</surefire.non-modular.system.args>
+        <surefire.non-modular.system.args>-ea -Duser.region=US -Duser.language=en ${surefire.jpda.args} ${surefire.extra.args} ${surefire.jacoco.args}</surefire.non-modular.system.args>
         <surefire.system.args>${modular.jdk.args} ${security.manager.props} ${surefire.non-modular.system.args}</surefire.system.args>
         <arquillian.servlet.protocol>Servlet 5.0</arquillian.servlet.protocol>
         <testLogToFile>true</testLogToFile>

diff --git a/testsuite/domain/src/test/resources/host-configs/host-primary-elytron.xml b/testsuite/domain/src/test/resources/host-configs/host-primary-elytron.xml
@@ -81,7 +81,6 @@
             <jvm-options>
                 <option value="-ea"/>
                 <option value="-XX:MetaspaceSize=96m"/>
-                <option value="-XX:MaxMetaspaceSize=256m"/>
             </jvm-options>
         </jvm>
     </jvms>

diff --git a/testsuite/domain/src/test/resources/host-configs/host-secondary-elytron.xml b/testsuite/domain/src/test/resources/host-configs/host-secondary-elytron.xml
@@ -84,7 +84,6 @@
             <jvm-options>
                 <option value="-ea"/>
                 <option value="-XX:MetaspaceSize=96m"/>
-                <option value="-XX:MaxMetaspaceSize=256m"/>
             </jvm-options>
         </jvm>
     </jvms>

diff --git a/...e/src/test/java/org/jboss/as/test/manualmode/messaging/CoreBridgeCallTimeoutTestCase.java b/...e/src/test/java/org/jboss/as/test/manualmode/messaging/CoreBridgeCallTimeoutTestCase.java
@@ -88,7 +88,7 @@ public static void startContainer() {
         System.out.println("jvm.args:" + System.getProperty("jvm.args"));
         System.out.println("basedir:" + System.getProperty("basedir"));
         System.setProperty("jvm.args", ORIGINAL_JVM_ARGS +
-                " -Xmx512m -XX:MaxMetaspaceSize=256m " +
+                " -Xmx512m " +
                 "-Dorg.jboss.byteman.verbose " +
                 "-Djboss.modules.system.pkgs=org.jboss.byteman " +
                 "-Dorg.jboss.byteman.transform.all " +

diff --git a/testsuite/mixed-domain/src/test/resources/primary-config/host-primary-elytron.xml b/testsuite/mixed-domain/src/test/resources/primary-config/host-primary-elytron.xml
@@ -59,7 +59,6 @@
             <jvm-options>
                 <option value="-server"/>
                 <option value="-XX:MetaspaceSize=96m"/>
-                <option value="-XX:MaxMetaspaceSize=256m"/>
             </jvm-options>
         </jvm>
     </jvms>