Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Commit 4170844

Browse files
committed
Pend spec broken on JRuby
1 parent 29ab2de commit 4170844

File tree

1 file changed

+14
-1
lines changed

1 file changed

+14
-1
lines changed

spec/rspec/support_spec.rb

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,20 @@ def object.some_method
196196
end
197197

198198
if defined?(Fiber) && RUBY_VERSION.to_f >= 2.0
199-
it "shares data across fibres" do
199+
broken_on_jruby =
200+
if RSpec::Support::Ruby.jruby?
201+
"As Fiber.new creates a new thread on JRuby this is currently " \
202+
"broken. There are alternative implementations that do work but " \
203+
"they cause issues for mocks, so given this is a minor edge case " \
204+
"and thread data is already broken, its acceptable. Pending " \
205+
"because future JRuby may fix this. see: "\
206+
"https://github.com/jruby/jruby/issues/1806 and " \
207+
"https://github.com/rspec/rspec-support/pull/610"
208+
else
209+
false
210+
end
211+
212+
it "shares data across fibers", :pending => broken_on_jruby do
200213
RSpec::Support.thread_local_data[:__for_test] = :oh_hai
201214

202215
Fiber.new do

0 commit comments

Comments
 (0)