the x button in popover is not visible when theme = "flatly"

[olivroy]

Describe the problem

The x button to close the popover is not very visible with theme = "flatly". It looks fine for the default shiny theme.

page_fixed(theme = bs_theme(version = 5, bootswatch = "flatly"), popover("Text", "new text", title = "popover"))

See screenshot:

Expected behavior

As an example, this works well:

page_fixed(theme = bs_theme(version = 5), popover("Text", "new text", title = "popover"))

[gadenbuie]

I think this is an issue that's present in Bootswatch, or it's an unfortunate combination of flatly's defaults.

We'll consider patching Bootswatch's version of flatly, but we generally prefer not to. Here's some code that you can use to change the values in your app in the mean time. Feel free to propose appropriate colors we could use as defaults.

theme = 
  bs_theme(version = 5, bootswatch = "flatly") |> 
  bs_add_rules(
    ".popover-header {
      --bs-popover-header-color: white;
      --bs-popover-header-bg: black;
    }"
  )