You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment, rdata is similar to pyarrow, etc. in the sense that it is optional, but still needed for testing and so I think it should be explicitly declared as a optional test dependency in setup.cfg.
This will mean it can be added as a pinned version to requirements/dev.txt rather than installed separately. This ensures consistency between local dev and CI and also ensures there is a consistent dependency resolution with dev.txt together with the rdata package.
I would like to do this, then the separate install step could be removed:
Incidentally, I am not sure why python -m pip install -e .[test] is necessary since the test extra is already included in the dev.txt file. I think this could be removed too.
The text was updated successfully, but these errors were encountered:
Thanks for this bit of cleanup, these seem like great ideas to do a bit of maintenance! I would want to make sure that there is at least one set of tests run that does not include all the test dependencies, but that case should be covered by the min test requirements CI run.
since the test extra is already included in the dev.txt file.
You are correct; it should be python -m pip install -e . 👀 pyarrow and fastparquet were not part of dev.txt when that line was added, but we have since updated that requirements file to be comprehensive.
At the moment,
rdata
is similar topyarrow
, etc. in the sense that it is optional, but still needed for testing and so I think it should be explicitly declared as a optional test dependency insetup.cfg
.This will mean it can be added as a pinned version to
requirements/dev.txt
rather than installed separately. This ensures consistency between local dev and CI and also ensures there is a consistent dependency resolution with dev.txt together with therdata
package.I would like to do this, then the separate install step could be removed:
pins-python/.github/workflows/ci.yml
Lines 90 to 95 in 70380b4
Incidentally, I am not sure why
python -m pip install -e .[test]
is necessary since thetest
extra is already included in thedev.txt
file. I think this could be removed too.The text was updated successfully, but these errors were encountered: