Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pins with latest version of paws.common 0.6.0 #778

Closed
DyfanJones opened this issue Sep 1, 2023 · 4 comments
Closed

Test pins with latest version of paws.common 0.6.0 #778

DyfanJones opened this issue Sep 1, 2023 · 4 comments

Comments

@DyfanJones
Copy link

Hi all,

I am in the process in releasing the latest version of paws.common 0.6.0 paws-r/paws#657. paws.common 0.6.0 comes with a new xml parser that has increased performance: paws-r/paws#621. However I am going around all paws dependent packages to ensure the new xml parser doesn't break any existing code.

Is it possible to run your existing tests with the latest version of paws.common 0.6.0? If not please let me know how to set up my environment so that I can test these changes on your behalf.

To install paws.common 0.6.0 you can use r-universe:

install.packages('paws.common', repos = 'https://paws-r.r-universe.dev')
@juliasilge
Copy link
Member

Great news about the new parser and yep, I am happy to do this! We typically use revdepcheck for this kind of task, but the situation is a little bit trickier here because the AWS tests only actually run (really read/write to S3) if you have specific env vars set and a specific bucket.

@juliasilge
Copy link
Member

I tested locally and in #779 and both look good to go (specifically see the check-boards action); you can consider pins all set. ✅

@DyfanJones
Copy link
Author

@juliasilge thanks for the testing. I will close this ticket :)

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants