Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pins published to Connect sometimes include username in name and sometimes do not #797

Open
juliasilge opened this issue Oct 31, 2023 · 1 comment
Labels
bug an unexpected problem or unintended behavior

Comments

@juliasilge
Copy link
Member

juliasilge commented Oct 31, 2023

When you write a pin to Connect, the displayed name changes depending on whether the last write did or did not include the username.

Screenshot 2023-10-31 at 1 18 42 PM

i.e. this reflects me doing pin_write(board, x, "fabulous_numbers") and pin_write(board, x, "julia.silge/superb_numbers"). I can change how either one displays by including (or not including) my username. I believe we should always include the username rather than switch back and forth.

As a reminder, pins for Python requires Connect users to include their username when writing and does not try to look up who they are.

@juliasilge juliasilge added the bug an unexpected problem or unintended behavior label Nov 3, 2023
@juliasilge
Copy link
Member Author

This happens because default_title() gets called before any board-specific methods:

title = title %||% default_title(name, data = x),

We don't have a chance to check/change name before the metadata is set up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

1 participant