From bb6e558ac560170fe4df4ebf2def231180752b44 Mon Sep 17 00:00:00 2001 From: Julia Silge Date: Thu, 27 Oct 2022 15:30:18 -0600 Subject: [PATCH 1/4] No more stringsAsFactors --- R/pin-read-write.R | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/R/pin-read-write.R b/R/pin-read-write.R index 2ea5df276..b9d7be142 100644 --- a/R/pin-read-write.R +++ b/R/pin-read-write.R @@ -183,7 +183,8 @@ object_read <- function(meta) { json = jsonlite::read_json(path, simplifyVector = TRUE), arrow = read_arrow(path), pickle = abort("'pickle' pins not supported in R"), - csv = utils::read.csv(path, stringsAsFactors = TRUE), + joblib = abort("'joblib' pins not supported in R"), + csv = utils::read.csv(path), qs = read_qs(path), file = abort(c( "Pin does not declare file type so can't be automatically read", From d3087d6067468ac64de5a8ae1b9fefa657975a6b Mon Sep 17 00:00:00 2001 From: Julia Silge Date: Thu, 27 Oct 2022 15:36:38 -0600 Subject: [PATCH 2/4] Update NEWS --- NEWS.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/NEWS.md b/NEWS.md index 8d1557e47..f6893b5a6 100644 --- a/NEWS.md +++ b/NEWS.md @@ -4,6 +4,9 @@ * Improved error message for `pin_versions()` (#657). +* Changed `type = "csv"` to use R's default value for `stringsAsFactors` i.e. + `FALSE` (#664). + # pins 1.0.3 * The `arrow` package is now suggested, rather than imported (#644, @jonthegeek). From 0f2f43cd4c3d363c345a0c72f7f8744915452a0e Mon Sep 17 00:00:00 2001 From: Julia Silge Date: Thu, 27 Oct 2022 15:37:21 -0600 Subject: [PATCH 3/4] Add error message for binary Python format we actually use --- R/pin-read-write.R | 1 + 1 file changed, 1 insertion(+) diff --git a/R/pin-read-write.R b/R/pin-read-write.R index b9d7be142..b608cf390 100644 --- a/R/pin-read-write.R +++ b/R/pin-read-write.R @@ -128,6 +128,7 @@ object_write <- function(x, path, type = "rds") { json = jsonlite::write_json(x, path, auto_unbox = TRUE), arrow = write_arrow(x, path), pickle = abort("'pickle' pins not supported in R"), + joblib = abort("'joblib' pins not supported in R"), csv = utils::write.csv(x, path, row.names = FALSE), qs = write_qs(x, path) ) From 7b5c35aee303e8b867a83f41995e4222e05ee9ca Mon Sep 17 00:00:00 2001 From: Julia Silge Date: Mon, 31 Oct 2022 14:18:37 -0600 Subject: [PATCH 4/4] Update NEWS --- NEWS.md | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/NEWS.md b/NEWS.md index f6893b5a6..c8726e215 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,11 +1,16 @@ # pins (development version) +## Breaking changes + +* Changed `type = "csv"` to use R's default value for `stringsAsFactors` i.e. + `FALSE` (#664). + +## Other improvements + * Added vignette describing how to manage custom formats (#631, @ijlyttle). * Improved error message for `pin_versions()` (#657). -* Changed `type = "csv"` to use R's default value for `stringsAsFactors` i.e. - `FALSE` (#664). # pins 1.0.3