Unwrapping extptr stored in capsules #1519
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R external pointers were wrapped as a python Capsule (in
r_extptr_capsule(...)
) but never properly unwrapped bypy_to_r
. As ther_extptr_capsule(...)
function stores the pointer address in the Capsule, and the corresponding R object in the Capsule's "context" field, the original R external pointer can be easily retrieved. This preserves the external pointer's finaliser.Example of usage:
This PR should not break any dependencies, as the capsule visible in python still stores the same pointer. I only changed its "name" field from
NULL
to"r_extptr"
to easily identify it.This PR fixes #1511