Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librelp does not emit error messages #130

Open
rgerhards opened this issue Nov 14, 2018 · 0 comments
Open

librelp does not emit error messages #130

rgerhards opened this issue Nov 14, 2018 · 0 comments

Comments

@rgerhards
Copy link
Member

... in many important cases, e.g. connection failure or breakage.

see also rsyslog/rsyslog#3294
@rgerhards rgerhards mentioned this issue Nov 14, 2018
Closed
rgerhards added a commit to rgerhards/rsyslog that referenced this issue Nov 14, 2018
@rgerhards
bugfix omrelp: emit error messages on suspension
afd8118 
The module did not emit error messages. Actually, it would have done
if librelp would emit them (callback is in place), but librelp does
not do. We expect to fix this at the librelp level as well. But to
make this work with all versions of librelp, we have added basic
error messages to omrelp. They may not be totally easy to understand,
but at least provide the librelp error code (that's the best we can
do in this situation).

see also rsyslog/librelp#130
closes rsyslog#3294
@rgerhards rgerhards mentioned this issue Nov 14, 2018
Merged
rgerhards added a commit to rgerhards/librelp that referenced this issue Nov 16, 2018
@rgerhards
emit more error messages, first increment
e20d328 
Adding error messages at very important places. While code
is far from perfect, this is very useful and should go into
the mail line ASAP. Will improve in follow-on commits.

see also rsyslog#130
@rgerhards rgerhards mentioned this issue Nov 16, 2018
Merged
rgerhards added a commit to rgerhards/librelp that referenced this issue Nov 19, 2018
@rgerhards
testbench: add test for receiver abort and restart
4210cea 
Also
- much improved testbench framework and tools to support
  this type of test. Done some general improvements to the
  tooling.
- imported rsyslog tool "chkseq" for checking
- added more error messages to code
  still not fully done and probably needs some review. but
  even for testbench runs the current set of error messages
  was too small to be useful.
  see also rsyslog#130
rgerhards added a commit to rgerhards/librelp that referenced this issue Nov 20, 2018
@rgerhards
testbench: add test for receiver abort and restart
a313f38 
Also
- much improved testbench framework and tools to support
  this type of test. Done some general improvements to the
  tooling.
- imported rsyslog tool "chkseq" for checking
- added more error messages to code
  still not fully done and probably needs some review. but
  even for testbench runs the current set of error messages
  was too small to be useful.
  see also rsyslog#130
rgerhards added a commit to rgerhards/librelp that referenced this issue Nov 21, 2018
@rgerhards
testbench: add test for receiver abort and restart
8f81ab8 
Also
- much improved testbench framework and tools to support
  this type of test. Done some general improvements to the
  tooling.
- imported rsyslog tool "chkseq" for checking
- added more error messages to code
  still not fully done and probably needs some review. but
  even for testbench runs the current set of error messages
  was too small to be useful.
  see also rsyslog#130
rgerhards added a commit to rgerhards/librelp that referenced this issue Nov 21, 2018
@rgerhards
testbench: add test for receiver abort and restart
089845a 
Also
- much improved testbench framework and tools to support
  this type of test. Done some general improvements to the
  tooling.
- imported rsyslog tool "chkseq" for checking
- added more error messages to code
  still not fully done and probably needs some review. but
  even for testbench runs the current set of error messages
  was too small to be useful.
  see also rsyslog#130
rgerhards added a commit to rgerhards/librelp that referenced this issue Nov 21, 2018
@rgerhards
testbench: add test for receiver abort and restart
a4079cf 
Also
- much improved testbench framework and tools to support
  this type of test. Done some general improvements to the
  tooling.
- imported rsyslog tool "chkseq" for checking
- added more error messages to code
  still not fully done and probably needs some review. but
  even for testbench runs the current set of error messages
  was too small to be useful.
  see also rsyslog#130
rgerhards added a commit to rgerhards/librelp that referenced this issue Nov 21, 2018
@rgerhards
testbench: add test for receiver abort and restart
710a2b7 
Also
- much improved testbench framework and tools to support
  this type of test. Done some general improvements to the
  tooling.
- imported rsyslog tool "chkseq" for checking
- added more error messages to code
  still not fully done and probably needs some review. but
  even for testbench runs the current set of error messages
  was too small to be useful.
  see also rsyslog#130
rgerhards added a commit to rgerhards/librelp that referenced this issue Nov 21, 2018
@rgerhards
testbench: add test for receiver abort and restart
a68d562 
Also
- much improved testbench framework and tools to support
  this type of test. Done some general improvements to the
  tooling.
- imported rsyslog tool "chkseq" for checking
- added more error messages to code
  still not fully done and probably needs some review. but
  even for testbench runs the current set of error messages
  was too small to be useful.
  see also rsyslog#130
rgerhards added a commit to rgerhards/librelp that referenced this issue Nov 21, 2018
@rgerhards
testbench: add test for receiver abort and restart
614fd34 
Also
- much improved testbench framework and tools to support
  this type of test. Done some general improvements to the
  tooling.
- imported rsyslog tool "chkseq" for checking
- added more error messages to code
  still not fully done and probably needs some review. but
  even for testbench runs the current set of error messages
  was too small to be useful.
  see also rsyslog#130
rgerhards added a commit to rgerhards/librelp that referenced this issue Nov 21, 2018
@rgerhards
testbench: add test for receiver abort and restart
2185862 
Also
- much improved testbench framework and tools to support
  this type of test. Done some general improvements to the
  tooling.
- imported rsyslog tool "chkseq" for checking
- added more error messages to code
  still not fully done and probably needs some review. but
  even for testbench runs the current set of error messages
  was too small to be useful.
  see also rsyslog#130
rgerhards added a commit to rgerhards/librelp that referenced this issue Nov 21, 2018
@rgerhards
testbench: add test for receiver abort and restart
1b2ffd5 
Also
- much improved testbench framework and tools to support
  this type of test. Done some general improvements to the
  tooling.
- imported rsyslog tool "chkseq" for checking
- added more error messages to code
  still not fully done and probably needs some review. but
  even for testbench runs the current set of error messages
  was too small to be useful.
  see also rsyslog#130
rgerhards added a commit to rgerhards/librelp that referenced this issue Nov 21, 2018
@rgerhards
testbench: add test for receiver abort and restart
15636f6 
Also
- much improved testbench framework and tools to support
  this type of test. Done some general improvements to the
  tooling.
- imported rsyslog tool "chkseq" for checking
- added more error messages to code
  still not fully done and probably needs some review. but
  even for testbench runs the current set of error messages
  was too small to be useful.
  see also rsyslog#130
rgerhards added a commit to rgerhards/librelp that referenced this issue Nov 21, 2018
@rgerhards
testbench: add test for receiver abort and restart
56a1580 
Also
- much improved testbench framework and tools to support
  this type of test. Done some general improvements to the
  tooling.
- imported rsyslog tool "chkseq" for checking
- added more error messages to code
  still not fully done and probably needs some review. but
  even for testbench runs the current set of error messages
  was too small to be useful.
  see also rsyslog#130
rgerhards added a commit to rgerhards/librelp that referenced this issue Nov 21, 2018
@rgerhards
testbench: add test for receiver abort and restart
3256009 
Also
- much improved testbench framework and tools to support
  this type of test. Done some general improvements to the
  tooling.
- imported rsyslog tool "chkseq" for checking
- added more error messages to code
  still not fully done and probably needs some review. but
  even for testbench runs the current set of error messages
  was too small to be useful.
  see also rsyslog#130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rgerhards