Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sciurus17_examplesのROS 2対応 #144

Merged
merged 30 commits into from
Nov 9, 2023
Merged

sciurus17_examplesのROS 2対応 #144

merged 30 commits into from
Nov 9, 2023

Conversation

Kuwamai
Copy link
Contributor

@Kuwamai Kuwamai commented Nov 8, 2023

What does this implement/fix?

  • sciurus17_examplesのROS 2対応です。
  • 各関節を制御するサンプルを追加しています。
  • カメラを使用したサンプル等は未対応です。

Does this close any currently open issues?

しません

How has this been tested?

ros2 launch sciurus17_examples example.launch.py example:='gripper_control'
ros2 launch sciurus17_examples example.launch.py example:='neck_control'
ros2 launch sciurus17_examples example.launch.py example:='waist_control'
ros2 launch sciurus17_examples example.launch.py example:='pick_and_place_right_arm_waist'
ros2 launch sciurus17_examples example.launch.py example:='pick_and_place_left_arm'

Any other comments?

Checklists

@Kuwamai Kuwamai added the Type: Feature New Feature label Nov 8, 2023
@Kuwamai Kuwamai requested a review from ShotaAk November 8, 2023 07:29
@Kuwamai Kuwamai self-assigned this Nov 8, 2023
@Kuwamai Kuwamai changed the base branch from master to ros2 November 8, 2023 09:25
Copy link
Contributor

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

サンプルの動作をgazebo上で確認しました。

コメントの確認お願いします。

sciurus17_examples/src/gripper_control.cpp Outdated Show resolved Hide resolved
sciurus17_examples/src/gripper_control.cpp Outdated Show resolved Hide resolved
sciurus17_examples/src/pick_and_place_left_arm.cpp Outdated Show resolved Hide resolved
sciurus17_examples/include/pose_presets.hpp Outdated Show resolved Hide resolved
Copy link
Contributor

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

@ShotaAk ShotaAk merged commit 572eefd into ros2 Nov 9, 2023
2 checks passed
@ShotaAk ShotaAk deleted the support_ros2_examples branch November 9, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants