-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not work with Javascript Maps #171
Comments
hmm ive actually switched form using Maps with seamless-immutable, but will be interested to know if they will be supported in the future |
Happy to accept a PR for them! |
Definitely, ill take a swing at it. I switched to storing everything as an object for now |
I'm having this problem also. Seems like a .set still works, but a .get does not get the object back properly. Tried a workaround to create a new map object => newMap = new Map(state.oldMap._mapData) seems to work. Not sure if there are other implications |
yeah sorry guys still havent had time to work on this, things at work have been crazy |
Finally got some time, picking this up ;) |
so i got drunk last night and worked on integrating maps, you can see a preview here: i'll need to do some clean up and refacter it a bit, add some tests, then ill drop the WIP tag from the pull request |
Soo.. are Maps and Sets supported now? I'd digging around trying to find out. |
@noahehall Any progress on this? |
I am using a javacript map to store data I retrieve from an api for a udacity project.
However, the data is not being saved to the immutable object.
here is a branch you can clone and verify:
here is picture of implementation
here is picture of error received from immutable
error TypeError: immutableDoesNotWorkWithJavascriptMaps.data.has is not a function(…)
Is there a workaround to get immutable to use Javascript maps? am i doing something wrong (very likely...)? or should I abandon seamless immutable?
The text was updated successfully, but these errors were encountered: