Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TypeScript support #9

Open
6 tasks
rtkg12 opened this issue Sep 30, 2020 · 9 comments
Open
6 tasks

Adding TypeScript support #9

rtkg12 opened this issue Sep 30, 2020 · 9 comments
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed up-for-grabs

Comments

@rtkg12
Copy link
Owner

rtkg12 commented Sep 30, 2020

It might be a good idea to start adding TypeScript support to the React and Node.js code as more people are starting to contribute to the repo. I'm just creating this issue to gauge interest in this. This would probably require at least a few people working on it since there are a lot of different files, so please feel free to indicate if you'd be interested in working on it.

This should be a straightforward PR and would help you to get acquainted with the codebase in case you're interested in contributing.

If you are interested in working on this, check off a file that isn't being worked on currently and submit a PR before starting work on the next item in the list. I have put a few files that should be easy to start with and I'll keep adding more as these ones get done.

Checklist:

React:

  • client/src/modules/Spotify.js
  • client/src/components/SeedTag.js
  • client/src/components/SongList.js
  • client/src/components/SavePlaylist.js
  • client/src/components/PlaylistSuccessPage.js
  • client/src/components/PlaylistCard.js
@rtkg12 rtkg12 added good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed up-for-grabs labels Sep 30, 2020
@togami2864
Copy link

Hello! I'm interested in this issue, especially for React.
If you're starting this project, I'd like to contribute!

@rtkg12
Copy link
Owner Author

rtkg12 commented Sep 30, 2020

@togami2864 Perfect. I've added a checklist with a few items that you can get started with. Let me know if you need anything else!

@togami2864
Copy link

@rtkg12 This project is built with CRA commands, so I need to set up the environment to develop with typescript.
Can I work from there?

@rtkg12
Copy link
Owner Author

rtkg12 commented Oct 13, 2020

@rtkg12 This project is built with CRA commands, so I need to set up the environment to develop with typescript.
Can I work from there?

@togami2864 Sorry, I'm confused. What do you mean?

@rtkg12
Copy link
Owner Author

rtkg12 commented Oct 13, 2020

Hey. I have been learning and working on react. I am new to open source and I would to love to contribute here. Can you assign me to this issue ?

@ya-nsh Please feel free to take any of the files in the main checklist and indicate you're working on that in a comment.

@ashalfarhan
Copy link

Hi @rtkg12 , is there anyone working with these issue ?, i've been trying to refactor some component to typescript, can i open a PR for this issue?

@Emeka-Ugbanu-hub
Copy link

I would love to help with this

@surajrane42
Copy link

Hello, I am interested to work on this. I will work on client/src/components/PlaylistCard.js file

@jimmy-chr
Copy link

jimmy-chr commented Nov 21, 2022

Hello, I don't know if this project is still alive, but it looked fun and I wanted to see how far I could get. I have a pull request open for adding typescript support for all files in the client workspace. I checked functionality of the logged in and logged out states, everything still seems to work, but maybe best to double check. There's some possible future improvements: there are some "any" types when I couldn't check the functionality to make sure, like in the SearchPlaylist component which doesn't seem to be actively used.

#32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed up-for-grabs
Projects
None yet
Development

No branches or pull requests

6 participants