-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Kramdown/Maruku problems WRT options #135
Comments
This might have been a leftover from a previous version. I'll have a look at it. |
The Markdown tests actually show this very clearly: tilt/test/tilt_markdown_test.rb Line 130 in a80ce03
begin
require 'kramdown'
class MarkdownKramdownTest < Test::Unit::TestCase
include MarkdownTests
template Tilt::KramdownTemplate
# Doesn't support escaping
undef test_escape_html_true
# Smarty Pants is *always* on, but doesn't support it fully
undef test_smarty_pants
undef test_smarty_pants_false
undef test_smarty_pants_true
end
rescue LoadError => boom
# It should already be warned in the main tests
end
begin
require 'maruku'
class MarkdownMarukuTest < Test::Unit::TestCase
include MarkdownTests
template Tilt::MarukuTemplate
# Doesn't support escaping
undef test_escape_html_true
# Doesn't support Smarty Pants, and even fails on ``Foobar''
undef test_smarty_pants
undef test_smarty_pants_false
undef test_smarty_pants_true
# Smart Quotes is always on
undef test_smart_quotes
undef test_smart_quotes_false
end
rescue LoadError => boom
# It should already be warned in the main tests
end |
I'm moving this under #189. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I read in the TEMPLATES.md
Could you please document these issues? The source code for Kramdown and Maruku is very small and clean, no problems are highlighted in the comments and the issues on GH do not show any problem with options (aside
:smart_quotes
, but that is handled just fine by the current code). Maybe that paragraph is a leftover from previous versions of Tilt?The text was updated successfully, but these errors were encountered: