Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor common executable code into an otto-exec crate #47

Open
rtyler opened this issue Nov 28, 2020 · 3 comments
Open

Refactor common executable code into an otto-exec crate #47

rtyler opened this issue Nov 28, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rtyler
Copy link
Owner

rtyler commented Nov 28, 2020

The sh step, local-orchestrator, and agent all have redundant code for executing and then streaming data from a subprocess.

This should get refactored into a common crate

@rtyler rtyler added enhancement New feature or request good first issue Good for newcomers labels Nov 28, 2020
@rtyler
Copy link
Owner Author

rtyler commented Nov 29, 2020

This code is the os_pipe using code that executes a subprocess and streams its stdout and stderr

@sladyn98
Copy link

@rtyler Hey is this something that a person trying to learn rust can pick up or is there something easier :)

@rtyler
Copy link
Owner Author

rtyler commented Feb 12, 2021

@sladyn98 sorry for the delay, I've been incredibly busy with work lately and haven't had much time to work on Otto much less anything else 😦

I think this should be a relatively straight forward learning exercise, but I probably wouldn't start with it as a first taste of Rust. Depending on your timezone overlap, if you ping me over the weekend in the #otto channel on Freenode I can try to help show you around. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants