Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git step's cache should not allow bleed through of authenticated repositories #59

Open
rtyler opened this issue Dec 1, 2020 · 0 comments
Labels
component/stdlib Step standard library issues

Comments

@rtyler
Copy link
Owner

rtyler commented Dec 1, 2020

The way that repository caches are implemented in the git step, once #58 is implemented, a pipeline running on an agent would be able to access another git repository even if it doesn't have the right authentication credentials granted to it.

This is basically because the agent side caching system is too stupid.

Some approaches here to consider:

  • Disable caching for authenticated repositories ☹️
  • Use the authentication details as part of the cache-path computation.

Technically any workload that is capable of running on the agent could do some directory traversal and potentially find cached data lying around if it's stored on the agent. This might be something worth addressing with a setting to not "trust" agents so much. Alternatively, if there were a simple way to chroot each pipeline 🤔

@rtyler rtyler added the component/stdlib Step standard library issues label Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/stdlib Step standard library issues
Projects
None yet
Development

No branches or pull requests

1 participant