Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image slide at cabins page cropped suboptimally #1076

Open
einar-m opened this issue Oct 4, 2022 · 1 comment
Open

Image slide at cabins page cropped suboptimally #1076

einar-m opened this issue Oct 4, 2022 · 1 comment

Comments

@einar-m
Copy link
Collaborator

einar-m commented Oct 4, 2022

Describe the bug

Maybe harsh to call this a bug, it's a minor issue.

The image slider on indokntnu.no/cabins crops too "short"/shallow, not sure what's the best term, when in

  • Phone, landscape
  • Tablet, portrait

To Reproduce

Steps to reproduce the behavior:

  1. Go to indokntnu.no/cabins on an iPad or iPhone
  2. Scroll down to image slider
  3. Rotate to landscape mode (iPhone) or portrait mode (iPad)
  4. See error

Expected behavior

The image slider should keep the same height width ratio as it does in all other configurations to properly display the full photo.

Screenshots

iPhone in landscape mode:

IMG_7815

iPad in portrait mode:

Photo slider issue

Tablet (please complete the following information):

  • iPad Pro 3rd gen
  • OS: iPadOS 15.6.1
  • Browser: Safari

Smartphone (please complete the following information):

  • Device: iPhone X
  • OS: 16.0
  • Browser: Safari

Additional context

Add any other context about the problem here.

@MagnusHafstad
Copy link
Contributor

I don't understand the problem. As far as I can tell everything seemes to be working well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants