Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to mrpt2 (master) #30

Open
jlblancoc opened this issue Sep 29, 2018 · 3 comments · May be fixed by #40
Open

Migrate to mrpt2 (master) #30

jlblancoc opened this issue Sep 29, 2018 · 3 comments · May be fixed by #40

Comments

@jlblancoc
Copy link

Hi Rubén @rubengooj ! ;-)

I found, via MRPT/mrpt#833, that your README instructions say:

Known Issues:
If working with the most recent versions of the MRPT library you might find some issues due to hard refactoring, for which we recommend to use this version instead (the last one we tested):

This issue is just a reminder to myself to try to make a pull request here to port the existing code to the latest version of MRPT (1.9.9, git master branch).

Would you please create a branch here towards which I could open the PR? For example, named mrpt2 or alike.
After that, you might decide whether to merge it against your master or not.

Cheers.
@jlblancoc jlblancoc mentioned this issue Sep 26, 2019
Closed
@akshay-krishnan
Copy link

akshay-krishnan commented Sep 26, 2019 •
edited
Loading

@jlblancoc has there been any progress on using the latest MRPT?

Thanks in advance.

@jlblancoc
Copy link
Author

jlblancoc commented Sep 26, 2019 •
edited
Loading

Hi.

Honestly, I couldn't give time to trying it, but would love to do it soon...
If anyone feels brave enough to attempt the port, there's a porting guide here which should cover most of the required changes...

This was referenced Nov 23, 2019
Closed
Open
Open
@jlblancoc
Copy link
Author

Kind reminder: this is already fixed here #40
;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CMake clean up; modern g2o and mrpt targets jlblancoc/pl-slam
2 participants
@jlblancoc @akshay-krishnan