Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLASS data data_bnds (uncertainties) are not compatible to the ILAMB code #112

Open
minxu74 opened this issue Dec 9, 2024 · 0 comments · May be fixed by #114 or rubisco-sfa/ILAMB-Data#78
Open

CLASS data data_bnds (uncertainties) are not compatible to the ILAMB code #112

minxu74 opened this issue Dec 9, 2024 · 0 comments · May be fixed by #114 or rubisco-sfa/ILAMB-Data#78

Comments

@minxu74
Copy link
Contributor

minxu74 commented Dec 9, 2024

CLASS data provide the standard deviations of observations as the uncertainties (data_bnds), but ILAMB will assume the data_bnds as lower and upper limits of the observations, i.e. data_bnds[...,0] is the lower limits and data_bnds[...,1] is the upper limits as seen in the following code.

https://github.com/rubisco-sfa/ILAMB/blob/6780ef0824a8a245ae60e518d5b5fc25f970f3d6/src/ILAMB/Variable.py#L1541C1-L1544C52.

Shall it be fixed in the ilamb code or in the ilamb-data?

@nocollier nocollier linked a pull request Dec 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant