From 6bfc61613c663d9e2f2f8b52c36649417417054d Mon Sep 17 00:00:00 2001 From: Stuart Chinery Date: Thu, 19 Oct 2023 22:57:17 +0100 Subject: [PATCH] PR Feedback --- CHANGELOG.md | 13 ++++--------- README.md | 4 ++-- UPGRADING.md | 6 ++++-- 3 files changed, 10 insertions(+), 13 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4968c50856..24e11590c7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,19 +1,14 @@ -### 1.9.1 (Next) +### 1.9.0 (Next) #### Features +* [#2353](https://github.com/ruby-grape/grape/pull/2353): Added Rails 7.1 support - [@ericproulx](https://github.com/ericproulx). +* [#2355](https://github.com/ruby-grape/grape/pull/2355): Set response headers based on Rack version - [@schinery](https://github.com/schinery). * Your contribution here. - + #### Fixes * Your contribution here. -* -### 1.9.0 (2023/10/18) - -#### Features - -* [#2353](https://github.com/ruby-grape/grape/pull/2353): Added Rails 7.1 support - [@ericproulx](https://github.com/ericproulx). -* [#2355](https://github.com/ruby-grape/grape/pull/2355): Set response headers based on Rack version - [@schinery](https://github.com/schinery). ### 1.8.0 (2023/08/30) diff --git a/README.md b/README.md index 365bd1b7ea..07ca9b36b0 100644 --- a/README.md +++ b/README.md @@ -160,9 +160,9 @@ content negotiation, versioning and much more. ## Stable Release -You're reading the documentation for the next release of Grape, which should be **1.9.1**. +You're reading the documentation for the next release of Grape, which should be **1.9.0**. Please read [UPGRADING](UPGRADING.md) when upgrading from a previous version. -The current stable release is [1.9.0](https://github.com/ruby-grape/grape/blob/v1.9.0/README.md). +The current stable release is [1.8.0](https://github.com/ruby-grape/grape/blob/v1.8.0/README.md). ## Project Resources diff --git a/UPGRADING.md b/UPGRADING.md index 329dd35315..f7c143133f 100644 --- a/UPGRADING.md +++ b/UPGRADING.md @@ -5,16 +5,18 @@ Upgrading Grape #### Response Headers -For Rack >= 3 the following response headers are returned lowercase: +As per [rack/rack#1592](https://github.com/rack/rack/issues/1592) Rack 3.0 is enforcing the HTTP/2 semantics, and thus treats all headers as lowercase. Starting with Grape 1.9.0, the following headers are now lowercase: * `content-type` * `x-cascade` -For Rack < 3 the following response headers are returned capitalized: +For Rack < 3 the following response headers are returned using HTTP/1 semantics, like so: * `Content-Type` * `X-Cascade` +See [#2355](https://github.com/ruby-grape/grape/pull/2355) for more information. + ### Upgrading to >= 1.7.0 #### Exceptions renaming