Converting snake_case_modules into CamelCaseModules #405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation to fix #403
Although this is mostly a straight-forward conversion, this is a breaking change. We might be able to stuff this change behind a feature flag, but it might be better to wait for a major version upgrade.
I did find an example that was a little weird and makes me not want to merge this change. If you look at
google_unittest.proto
:These use a half camel-case half snake-case name for the group extension. This new change now converts this into a full camel-case class:
And that might be a little weird, but if we are going to make a breaking change here, it might be worth it? I suppose we could see if everything up until the snake-case edition is camel-case, and if so, leave it be?
cc @liveh2o @abrandoned