Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to present all fields of a message for JSON #413

Open
keyuebao opened this issue Jan 9, 2020 · 0 comments
Open

Add option to present all fields of a message for JSON #413

keyuebao opened this issue Jan 9, 2020 · 0 comments

Comments

@keyuebao
Copy link

keyuebao commented Jan 9, 2020

It’s surprising when Message.new(array: []).to_json_hash gets encoded to {}.

A decoded proto Message will still respond to the array field, supplying the default value. A JSON response however, will fail to do so. This seems inconsistent. Happy to submit a PR for this!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@keyuebao