Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-packed fields are encoded as packed #420

Open
podruh opened this issue Oct 29, 2020 · 0 comments
Open

Non-packed fields are encoded as packed #420

podruh opened this issue Oct 29, 2020 · 0 comments

Comments

@podruh
Copy link

podruh commented Oct 29, 2020

We have found that fields marked as non-packed are still being encoded as packed.
I have dug around and found the issue in lib/protobuf/field/base_field.rb:58 which contains line
@packed = @repeated && options.key?(:packed)

This line should also check the value in options[:packed].

This also relates to #414

Gem version: v3.10.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant