Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qualifiedValueShape not working as expected #5

Open
saumier opened this issue May 26, 2024 · 5 comments
Open

qualifiedValueShape not working as expected #5

saumier opened this issue May 26, 2024 · 5 comments

Comments

@saumier
Copy link

saumier commented May 26, 2024

The behaviour of sh:qualifiedValueShape does not appear to be working as specified in SHACL Spec https://www.w3.org/TR/shacl/#QualifiedValueShapeConstraintComponent

I have created a repo with examples:
https://github.com/saumier/shacl-test-qualified-value-shape

@saumier
Copy link
Author

saumier commented May 26, 2024

@gkellogg FYI I took a quick look into qualifier_value.rb:20 and this jumped out as needing to fix:
max_count = params[:qualifiedMinCount] which should be max_count = params[:qualifiedMaxCount]

But this did not fix the issue. Looks like the params are not getting added to the operands.

@gkellogg
Copy link
Member

That seems right. Would you consider a PR including a test for this?

@saumier
Copy link
Author

saumier commented May 26, 2024

I'd love to give it a whirl. Let me try ;-)

@saumier
Copy link
Author

saumier commented May 27, 2024

I'm having a little trouble running rspec. I came across https://w3c.github.io/data-shapes/data-shapes-test-suite. Have the shacl.rb implementation reports ever been submitted? This is something of interest to me.

@gkellogg
Copy link
Member

Never submitted a report, but the infrastructure for generating it should be there.

There is some code to look for the test suite files relative to /spec. (It works better when those tests are local). Look in spec/suite_helper.rb for the file open patch that looks for them.

you can also email me directly for help in working with the gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants