-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenSSL::ASN1::ObjectId#== raises for OIDs without a known name #791
Comments
rhenium
added a commit
to rhenium/ruby-openssl
that referenced
this issue
Aug 24, 2024
Compare by the dotted decimal notation rather than the NID. OpenSSL::ASN1::ObjectId can store OIDs that are not registered in OpenSSL's internal table. NID is not defined for such an OID, but it is not an error. The == method also should not raise TypeError if the other object is not an instance of OpenSSL::ASN1::ObjectId. Fixes: ruby#791
rhenium
added a commit
to rhenium/ruby-openssl
that referenced
this issue
Aug 24, 2024
Compare by the dotted decimal notation rather than the NID. OpenSSL::ASN1::ObjectId can store OIDs that are not registered in OpenSSL's internal table. NID is not defined for such an OID, but it is not an error. The == method also should not raise TypeError if the other object is not an instance of OpenSSL::ASN1::ObjectId. Fixes: ruby#791
Merged
It should be implemented this way (or by #792 will fix it. |
hsbt
pushed a commit
to hsbt/ruby
that referenced
this issue
Nov 14, 2024
Compare by the dotted decimal notation rather than the NID. OpenSSL::ASN1::ObjectId can store OIDs that are not registered in OpenSSL's internal table. NID is not defined for such an OID, but it is not an error. The == method also should not raise TypeError if the other object is not an instance of OpenSSL::ASN1::ObjectId. Fixes: ruby/openssl#791
hsbt
pushed a commit
to ruby/ruby
that referenced
this issue
Nov 14, 2024
Compare by the dotted decimal notation rather than the NID. OpenSSL::ASN1::ObjectId can store OIDs that are not registered in OpenSSL's internal table. NID is not defined for such an OID, but it is not an error. The == method also should not raise TypeError if the other object is not an instance of OpenSSL::ASN1::ObjectId. Fixes: ruby/openssl#791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
outputs
when I would expect both oids to compare equal. I am unsure why
OBJ_txt2nid
is being used instead of comparing the underlyingoid
valueon 3.2.0
OpenSSL 3.2.0 23 Nov 2023
The text was updated successfully, but these errors were encountered: