Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

escape URL component in location header #111

Closed
wants to merge 1 commit into from
Closed

escape URL component in location header #111

wants to merge 1 commit into from

Conversation

noraj
Copy link

@noraj noraj commented Feb 17, 2023

brings non-ASCII (eg. Unicode) support

fix #110

@noraj
escape URL component in location header
1156c19 
brings non-ASCII (eg. Unicode) support
@jeremyevans
Copy link
Contributor

If location is already correctly percent escaped, this would double escape it and break working code, which I don't think is acceptable.

@noraj noraj closed this Feb 17, 2023
@noraj
Copy link
Author

noraj commented Feb 17, 2023

Yeah this solution is too naive. A more global approach should be taken.

@noraj noraj deleted the patch-1 branch February 17, 2023 17:44
@jeremyevans jeremyevans mentioned this pull request Feb 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unicode handling in header location
2 participants
@noraj @jeremyevans