Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncap submissions for Additional Expenses and improve UX #5773

Closed
2 tasks
elasticspoon opened this issue May 27, 2024 · 6 comments · Fixed by #5908
Closed
2 tasks

Uncap submissions for Additional Expenses and improve UX #5773

elasticspoon opened this issue May 27, 2024 · 6 comments · Fixed by #5908
Labels
Difficulty: Intermediate Spans multiple domains or requires more advanced coding knowledge

Comments

@elasticspoon
Copy link
Collaborator

elasticspoon commented May 27, 2024

What type(s) of user does this feature affect?

  • supervisors
  • admins
  • volunteers

Description

If an org has enabled additional expenses the last step of the case contact form (case_contacts/:id/form/expenses) allows the volunteer to add additional expenses.

Image

Currently there is a cap of 10 expenses. When you hit 10 the button remains but you cannot add any more.

Image

We have https://www.stimulus-components.com/docs/stimulus-rails-nested-form/ in the application. It could potentially be of use (unless needed I would suggest using the non-extended version of the stimulus controller).

Completion Criteria:

  • Use some javascript to uncap the amount of expenses
  • Add a way to remove expenses.

How to access the QA site

Login Details:
Link to QA site

Login Emails:

password for all users: 12345678

Questions? Join Slack!

We highly recommend that you join us in slack #casa channel to ask questions quickly. And discord for office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

@elasticspoon elasticspoon added Ruby for Good 2024 DC Difficulty: Intermediate Spans multiple domains or requires more advanced coding knowledge labels May 27, 2024
@shacon
Copy link
Contributor

shacon commented Jun 19, 2024

I would like to work on this!

Copy link

This issue has been inactive for 240 hours (10.00 days) and will be unassigned after 120 more hours (5.00 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

@shacon
Copy link
Contributor

shacon commented Jul 1, 2024

This issue has been inactive for 240 hours (10.00 days) and will be unassigned after 120 more hours (5.00 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

Still working on this!

Copy link

This issue has been inactive for 262 hours (10.92 days) and will be unassigned after 98 more hours (4.08 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

Copy link

This issue has been inactive for 382 hours (15.92 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

@shacon
Copy link
Contributor

shacon commented Jul 21, 2024

pr for this has updated changes: https://github.com/rubyforgood/casa/pull/5908/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty: Intermediate Spans multiple domains or requires more advanced coding knowledge
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants