Add a confirmation page to partner requests. #3052
Comments
|
@cielf I'd love to take this one :) |
|
FYI the same functionality, but for distributions is in the backlog as well. |
|
This issue has been inactive for 251 hours (10.46 days) and will be automatically unassigned after 109 more hours (4.54 days). |
|
I'll need some help thinking of the UX for this |
|
This issue has been inactive for 250 hours (10.42 days) and will be automatically unassigned after 110 more hours (4.58 days). |
|
This issue has been inactive for 370 hours (15.42 days) and is past the limit of 360 hours (15.00 days) so is being unassigned. |
|
This is also blocked on #3214 . |
|
I'm pretty sure this is no longer blocked on #3214. Not sure what the issue was that was blocking it before -- @edwinthinks - can you clarify -- is it blocked for you, because of need of help with thinking of the UX, or blocked for anybody? |
|
I don't think this is still blocked. |
|
I can take this one also |
|
@lokisk1155 this and the other one are both pretty hefty pieces of work. I'd suggest picking one. |
|
Well - it's also possible that you'll run out of time on one before finishing the other -- it's the same pattern, but @dorner is right that they are good chunks of work. They are also old enough that the odds of someone else taking the other one in the meantime is relatively low. |
|
This issue has been inactive for 248 hours (10.33 days) and will be automatically unassigned after 112 more hours (4.67 days). |
|
Just posting a status here (still wip), I had the family request confirmation working in an earlier commit at comment here, but after rebasing, it no longer works. It thinks the request is invalid (completely empty request) even though the request is actually valid. Will investigate further... |
…r quantity request
|
Hey @danielabar -- Just thought you should be aware of the [PACKS] line of issues if you aren't already. I'm pretty sure this will be going in well before we're ready to enable them, but we will be needing to update this as well (after the fact) to bring it in line before we do. [So many moving parts!] That probably doesn't have to be you. |
|
I'm not familiar with the PACKS feature, can you point me to the ticket(s). For the partner confirmation, it's working and tested, just left with some refactoring to do. |
…r quantity request
1. Quantity requests 2. Individual requests 3. Family requests
|
#s 4396 to 4308 plus 4501 (an overall qa pass) |
Swapping out after_save for after_validation AR callback supports the use of the total_items method on a Request model that has been initialized, but not yet saved to the database.
|
Update: Addressed PR feedback although the most recent commit has a test failure when the events flag is on: https://github.com/rubyforgood/human-essentials/actions/runs/10237022770/job/28319804139 Will try to enable that flag locally and see if/how that distribution test fails. |
|
Update: All the tests are passing now, although I didn't change anything from yesterday's comment when there was a failure. Wondering if someone re-ran the tests on CI and that's a known intermittent? |
Summary
Add a confirmation step to partner requests
Justification
Non-profits are often staffed with folks with limited technical skills and sometimes make mistakes with their requests. This puts and extra burden on the essentials banks as they then need to get in contact with their partners and see if they really did intend to order 5000 rather than their usual 500 diapers. We need to add in a confirmation page summarizing the request and ask for confirmation from the partner before this request is placed to the diaper bank.
Details
There are three different ways to make a request (partners/requests/new, partners/family_requests/new, partners/individuals_request/new). The confirmation page information is the same for each of them
It will show a list of the items requested and number requested for each, along with the text "Please confirm that the above list is what you meant to request" and buttons "No, I need to change something." and "Yes, it's right"
Additionally, if a quota is in place, warn partners from accidentally making a request that is over the quota unintentionally. "Oops! You are ordering 9999999 of something, are you sure?"
Clicking "No..." will take them back to the requests page they came from so that they can adjust their ask. Clicking "Yes..." will take them to the current
Clicking "Yes" will submit the request and show the submitted page for that request, as it does now.
Things we should know
History: This was raised by Sean a long time ago as rubyforgood/partner#354. There was even a pull request for it. It was closed but remained on the project initiatives board. CL took the backlogs for partner-facing items to the July 2022 partnerbase working group, where this was identified as one of the higher priority asks, as it does burden the essentials banks.
There has been some discussion in the partnerbase working group about whether the quota is a weekly or monthly quota. For the purposes of this issue, treat it as a per request quota of total items, as most partners only do one request for month.
Criteria for Completion
-[] Add in a confirmation page when partners issue a request, as described above
-[] Add in relevant tests
-[] Tests pass
The text was updated successfully, but these errors were encountered: