Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Admin users Organization drop down doesn't work #3828

Closed
2 tasks done
dorner opened this issue Aug 13, 2023 · 7 comments · Fixed by #3919
Closed
2 tasks done

[BUG]: Admin users Organization drop down doesn't work #3828

dorner opened this issue Aug 13, 2023 · 7 comments · Fixed by #3919
Assignees
Labels

Comments

@dorner
Copy link
Collaborator

dorner commented Aug 13, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When creating or updating a user in the admin interface, the "Organization" drop-down is tied to that user's organization_id. However, this field is no longer used for anything as it's been replaced with roles.

Expected Behavior

The user should be given the org_user role for that organization when saving the page.

Steps To Reproduce

  1. Log in as a super user.
  2. Go to Users -> All Users.
  3. Edit a user.
  4. Update the Organization field to a different value.
  5. Log in as that user.
  6. The organization has not changed.

Environment

- OS:
- Node:
- npm:

Criteria for Completion

  • [] Editing a user changes the org role.
  • [] Adding a user sets the org role correctly.
  • [] Solution should not use organization_id on the users table in any way.

Anything else?

No response

Code of Conduct

  • I've read the Code of Conduct and understand my responsibilities as a member of the Ruby for Good community
@torienyart
Copy link
Contributor

I'd like to tackle this one if its okay?

@dorner
Copy link
Collaborator Author

dorner commented Aug 18, 2023

It's yours!

@github-actions
Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions
Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

@yonas44
Copy link
Contributor

yonas44 commented Oct 16, 2023

Can I take this one? I have actually traced the bug as provided by @dorner and would like to provide a solution for it, thanks!

@dorner
Copy link
Collaborator Author

dorner commented Oct 20, 2023

Go for it!

@yonas44
Copy link
Contributor

yonas44 commented Oct 23, 2023

Hello @dorner, I have made some changes to resolve the issue, could you please review it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants