Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed data for distributions with shipping should also have shipping cost #3846

Closed
2 tasks
awwaiid opened this issue Aug 20, 2023 · 6 comments
Closed
2 tasks
Labels
Good First Issue Suitable for users that are newer or less experienced stale

Comments

@awwaiid
Copy link
Collaborator

awwaiid commented Aug 20, 2023

Summary

The seed data for distributions that use the delivery option shipping should also have a shipping cost

Why

Realism

Details

Currently, the seed data for distributions that use the delivery option shipping do not have a shipping cost included. Please add the shipping cost to those distributions that have shipping, and only the distributions that have shipping.

Criteria for completion

  • The seed data includes shipping cost for those distributions that use the delivery type "shipping"
  • Ensure that the seed data includes some distributions that use delivery type "shipping" :)
@awwaiid awwaiid added the Good First Issue Suitable for users that are newer or less experienced label Aug 20, 2023
@chaitali-khangar
Copy link
Contributor

Hello, @awwaiid . Could I take care of this task?
Should we make modifications to the current seed data, or is it preferable to generate new seed data?

@dorner
Copy link
Collaborator

dorner commented Aug 21, 2023

It should be fine to modify the existing seed. Give it a go!

@github-actions
Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions
Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

@chaitali-khangar
Copy link
Contributor

@dorner, do you think it's time to mark this ticket as closed since we've successfully completed it?

@dorner
Copy link
Collaborator

dorner commented Sep 28, 2023

It is indeed! Thanks!

@dorner dorner closed this as completed Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Suitable for users that are newer or less experienced stale
Projects
None yet
Development

No branches or pull requests

3 participants