Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "prior year" to the date range drop downs #4082

Open
2 tasks
cielf opened this issue Feb 4, 2024 · 9 comments
Open
2 tasks

Add "prior year" to the date range drop downs #4082

cielf opened this issue Feb 4, 2024 · 9 comments

Comments

@cielf
Copy link
Collaborator

cielf commented Feb 4, 2024

Summary

Add "prior year" to the date range drop downs throughout.

Why?

In January, a lot of people are trying to get information about the year before. They very often are not entering the date range correctly, which causes exceptions

Details

The prior year range should be January 1 - December 31 of the calendar year preceding the current calendar year. i.e. in 2024 it would be January 1 2023 - December 31 2023. I suggest that you can likely use the "this year" selection as a model.

This might conflict with the Dashboard change that is coming in in the next few weeks at time of writing (January 2024). Be aware of that.

Criteria for completion

  • The year range exists and is available on all the reports/indices that use date range filtering
  • Tests to demonstrate the change
@cielf cielf added BLOCKED This issue is blocked by another Difficulty—Beginner labels Feb 4, 2024
@Gabe-Torres
Copy link
Contributor

Is this issue still open? Would love to take it

@cielf
Copy link
Collaborator Author

cielf commented Apr 7, 2024

Hey @Gabe-Torres, it's technically open, but blocked by a PR that's currently in review. @awwaiid -- would it make sense for @Gabe-Torres to take this on branching off of the Dashboard branch?

@cielf cielf removed the BLOCKED This issue is blocked by another label May 26, 2024
@cielf
Copy link
Collaborator Author

cielf commented May 26, 2024

No longer blocked -- Dashboard has been merged into main.

@noah-puckett
Copy link
Contributor

Hi @cielf, could I try taking this one on?

@cielf
Copy link
Collaborator Author

cielf commented Jul 3, 2024

Sure!

@noah-puckett
Copy link
Contributor

Currently a bit blocked due to codespaces no longer working for me, due to getting failed javascript runtime errors as described in this PR.

@jimmyli97
Copy link
Contributor

Currently a bit blocked due to codespaces no longer working for me, due to getting failed javascript runtime errors as described in this PR.

For now you can run nvm install node followed by rbenv init in the shell of your choice and that should resolve the error until the PR gets merged

Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants