Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change style of messages regarding inactive items #4242

Closed
cielf opened this issue Mar 31, 2024 · 17 comments · Fixed by #4462
Closed

Change style of messages regarding inactive items #4242

cielf opened this issue Mar 31, 2024 · 17 comments · Fixed by #4462

Comments

@cielf
Copy link
Collaborator

cielf commented Mar 31, 2024

Summary

Colour change for messages regarding inactive items

Why

We have been asked to make warning messages less scary. Also, these are informational more than warning

Details

Make these particular messages plain text.

This is a good first items level of difficulty, but it takes a lot of going through things to demonstrate.

how to see all the messages we are talking about

  • set up a new distribution (Distributions | New Distribution) , a new donation (Donation |New Donation), and a new purchase (Purchases | New Purchase) that are all using a particular item (e.g. Adult Briefs L/XL)
  • then go into Inventory | Inventory Adjustments
  • Enter new Inventory Adjustments to take the levels for that item for each storage location down to 0
  • Go to Inventory|Items & Inventory
  • Deactivate the item
  • Go to Distiributions
    • you should see a "Has Inactive Items" message. The style of this message should be changed
    • click View on that item, and scroll to the bottom
      • you should see a message indicating why you can't correct this. The style of this message should be changed
  • Go to Donations
  • Click view on the donation you entered and scroll to the bottom
      • you should see a message indicating why you can't correct this. The style of this message should be changed
  • Go to Purchases
    • Click view on the purchase you entered and scroll to the bottom
      • you should see a message indicating why you can't correct this. The style of this message should be changed

Criteria for completion

  • [ ]styles of the indicated messages are changed
  • [ ]please provide screenshots with your PR
@cielf cielf added Difficulty—Beginner Help Wanted Groomed + open to all! labels Mar 31, 2024
@AweysAhmed
Copy link
Contributor

@cielf may I work on this issue?

@dorner
Copy link
Collaborator

dorner commented Apr 5, 2024

It's yours!

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Apr 5, 2024
@AweysAhmed
Copy link
Contributor

It's yours!

Thank you!

@AweysAhmed
Copy link
Contributor

@dorner @cielf just wanted to provide an update. I'll be working on this week and weekend.

Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the stale label May 24, 2024
@AweysAhmed
Copy link
Contributor

Sorry for the delay. Work and life got busy but if I don't start this weekend, I will remove myself from this issue.

@AweysAhmed
Copy link
Contributor

I am working on this. I have found an issue that I will bring up in slack.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Automatically unassigned after 7 days of inactivity.

@AweysAhmed
Copy link
Contributor

@cielf @dorner I started working on this to recreate the issue but I ran into a few issues trying to do that. May I still have this?

@cielf
Copy link
Collaborator Author

cielf commented Jun 5, 2024

Reassigning it to you.

Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

@AweysAhmed
Copy link
Contributor

Reassigning it to you.

I have a PR that I’m working on for this issue. I didn’t think it would unassign me.

I assume if I push up changes it won’t be labeled inactive.

May I have this again?

@cielf
Copy link
Collaborator Author

cielf commented Jun 13, 2024

Alas, it's not that smart. I've reassigned you.

Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

@AweysAhmed
Copy link
Contributor

@cielf @dorner I have a PR upready for review. Do I need to have this issue assigned back to me?

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Automatically unassigned after 7 days of inactivity.

@cielf
Copy link
Collaborator Author

cielf commented Jul 2, 2024

This has a PR in review.

cielf added a commit that referenced this issue Jul 3, 2024
…ive-items-message

Fixes #4242 so that  css file doesn't make the warning message look scary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants