-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PACKS] # 4 Show the custom units when displaying the request to the partner #4399
Comments
@awwaiid + @FelipeGithub24 are grabbing this |
I will take this one with Brock..! |
Nevermind! We are going to do #6 first instead :) |
awwaiid
added a commit
that referenced
this issue
Jul 14, 2024
awwaiid
added a commit
that referenced
this issue
Jul 14, 2024
awwaiid
added a commit
that referenced
this issue
Jul 14, 2024
And also fix traits, which seem like they shouldn't have worked this way. [#4399]
awwaiid
added a commit
that referenced
this issue
Jul 14, 2024
There are unfortunately existing specs which don't pass in valid data for building out the item_requests, so here we make it an explicit trait that must be requested. [#4399]
cielf
added a commit
that referenced
this issue
Jul 27, 2024
Partner request units display (packs-4) #4399
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Show the custom units when displaying the individual request to the partner(assumes [PACKS] #3 is complete)
Why
This is step #4 of adding the ability to specify "packs" versus "individual" for requests
Details
This is for when we show the individual request to the partner, when they save their request. For the lists of requests, see [PACKS] # 6.
The unit should be put between the number and the word "of" (if and only if a non-default unit is selected).
N.B.
All of the changes for PACKS must be implemented behind a flipper flag "enable_packs"
1/ Flipper works by enabling or disabling a tag (for the PACKS issues, that is enable_packs)
2/ Here is a code snippet illustrating how to use it in your code, with enable_packs as the example tag:
if Flipper.enabled?(:enable_packs)
// do the thing we are guarding with the tag
end
3/ How to check out if it works manually (with the example tag: enable_packs ):
You have to enable the flipper tag on your localhost (note - the tag is stored in your db, so if you reset your db you have to do it again)
localhost:3000/flipper
userid: admin
password: password
Sign In
Click: Add feature
enable_packs
Click: Add feature
Click: Fully enable
To set it back (to check that your nifty changes haven’t broken anything when the flag is off)
Sign in as above:
click on “enable_packs”
click “Delete”
type enable_packs in the “Are you sure” dialog and click ok
Criteria for completion
Background
The following sections have been identified as required for the PACKS implementation. These should be implemented in numerical order.
The text was updated successfully, but these errors were encountered: