Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PACKS] #5 Add custom request units (if any) to the confirmation email for partner requests. #4400

Closed
2 tasks
cielf opened this issue May 30, 2024 · 3 comments · Fixed by #4421
Closed
2 tasks
Assignees
Labels
Ruby for Good 2024 DC Issues for RFG 2024 DC stale

Comments

@cielf
Copy link
Collaborator

cielf commented May 30, 2024

Summary

Add custom request units (if any) to the confirmation email for partner requests.(assumes [PACKS] step-3 (#4398) is complete)

Why

This is step-5 of adding the ability to specify "packs" versus "individual" for requests

Details

Add the units (only if selected and not the default ) at the end of each description in the confirmation email for partner requests.
e.g.
Diapers Size 2 - 10 packs
Diapers Size 5 - 50

Image

N.B.

All of the changes for PACKS must be implemented behind a flipper flag "enable_packs"

Criteria for completion

  • functionality as described above
  • tests that support the functionality as described above

Background

The following sections have been identified as required for the PACKS implementation. These should be implemented in numerical order.

Image

@cielf cielf added the Ruby for Good 2024 DC Issues for RFG 2024 DC label May 30, 2024
@awwaiid awwaiid added this to the Packs milestone May 31, 2024
@FelipeGithub24
Copy link
Contributor

I would like to work on this one...

Copy link
Contributor

github-actions bot commented Jul 2, 2024

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the stale label Jul 2, 2024
@cielf
Copy link
Collaborator Author

cielf commented Jul 2, 2024

PR #4419 was superseded by #4421, which has been merged.

@cielf cielf closed this as completed Jul 2, 2024
@awwaiid awwaiid linked a pull request Jul 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ruby for Good 2024 DC Issues for RFG 2024 DC stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants