Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The order of items in inventory adjustment is a bit odd -- try it with a new storage location to see. #4522

Closed
2 tasks
cielf opened this issue Jul 14, 2024 · 11 comments · Fixed by #4541
Closed
2 tasks
Assignees
Labels
Good First Issue Suitable for users that are newer or less experienced

Comments

@cielf
Copy link
Collaborator

cielf commented Jul 14, 2024

Summary

The order of items in inventory adjustment is a bit odd. It might be by order created? Make it alphabetical

Why change

consistency

Details

Recreation -- you can see this clearly on your local (or on staging) by creating a new storage location, then a new inventory adjustment for that location. If you scroll down through the items in the drop down for items, you will see that they are not in alpha order. They should be.

Critera for completion

  • order of items in drop downs in inventory adjustment are alphabetical by name
  • automated tests to demonstrate this functionality
@cielf cielf added Help Wanted Groomed + open to all! Difficulty—Beginner Good First Issue Suitable for users that are newer or less experienced and removed Help Wanted Groomed + open to all! Difficulty—Beginner labels Jul 14, 2024
@amanbhargav
Copy link
Contributor

I would like to work on this😄

@cielf
Copy link
Collaborator Author

cielf commented Jul 19, 2024

Please do.

@amanbhargav
Copy link
Contributor

Hello @cielf , Are you referencing the dropdown for items in the image below, which appears when creating a new inventory adjustment for a newly created storage location? If this is not the correct dropdown, could you please provide a screenshot of the part you are referring to?
Screenshot from 2024-07-20 00-40-05

@cielf cielf closed this as completed Jul 19, 2024
@cielf cielf reopened this Jul 19, 2024
@cielf
Copy link
Collaborator Author

cielf commented Jul 19, 2024

Yes, that's it. And only on new storage locations - which is odd -- even if you add a new item, it gets put in the right place on the old storage locations.

@amanbhargav
Copy link
Contributor

So what needs to be done on this issue?

@cielf
Copy link
Collaborator Author

cielf commented Jul 19, 2024

Ok -- if you have a new storage location, the items are not appearing in alphabetical order in that dropdown . They should.
Screenshot 2024-07-19 at 5 13 03 PM

@cielf
Copy link
Collaborator Author

cielf commented Jul 19, 2024

I don't know why they aren't -- that's part of the task.

@amanbhargav
Copy link
Contributor

Yes, need more debugging because when I am testing on staging, it is showing in alphabetical order.

@cielf
Copy link
Collaborator Author

cielf commented Jul 19, 2024

You added new storagelocation02? If you go all the way to the very end, you'll see that Fantastic Item is at the end, out of order. I think the seed on staging may be adding things in alpha order for some reason (though it doesn't on local? That is very strange) But the new item I added this morning (which will be gone tomorrow) is appearing out of order.

(If it's not the day I wrote this, you'll need to add another item as well if you are troubleshooting on staging)

@amanbhargav
Copy link
Contributor

Got it. I was able to recreate the issue in my local environment following your steps. It looks like the items are not being added in alphabetical order for some reason. I'll investigate further to identify the cause. Thank you for pointing this out.

@amanbhargav
Copy link
Contributor

amanbhargav commented Jul 22, 2024

Please review this pull request

@awwaiid awwaiid modified the milestone: Tasks 2024 Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Suitable for users that are newer or less experienced
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants