Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add In Kind value to Donation export #4524

Closed
2 tasks
cielf opened this issue Jul 14, 2024 · 7 comments · Fixed by #4661
Closed
2 tasks

Add In Kind value to Donation export #4524

cielf opened this issue Jul 14, 2024 · 7 comments · Fixed by #4661
Labels

Comments

@cielf
Copy link
Collaborator

cielf commented Jul 14, 2024

Summary

Add Donation-level in-kind value to Donation export

Why?

Helps the banks with external paperwork

Details

Add the in-kind value, at a donation level, to the Donation export. Put it before the item breakdown

Note

  1. We checked with the user who requested this -- they said that item-level would be lovely, but not necessary. Unless someone specifically needs it, let's leave it out for reasons of file size and manageablilty of working with the exported file.
  2. We will need to highlight this in the announcements when it goes in, as it will need people to adjust their external use of the export.

Criteria for completion

  • In-kind value included in donation export, before the items
  • tests to demonstrate
@cielf cielf added Help Wanted Groomed + open to all! Difficulty—Beginner labels Jul 14, 2024
@Sahil-Dash
Copy link

can you just tell me where in the code file responsible for generating the Donation export, so that i can navigate to it directly and add donation level in it after understanding the code

@cielf
Copy link
Collaborator Author

cielf commented Jul 15, 2024

To navigate to the donation export, sign in as [email protected], click "Donations', the "All Donations", then "Export Donations".
You'll likely want to look at app/services/exports/export_donations_csv_service.rb

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Jul 15, 2024
@awwaiid awwaiid modified the milestone: Tasks 2024 Jul 28, 2024
Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Automatically unassigned after 7 days of inactivity.

@cielf cielf added Help Wanted Groomed + open to all! and removed stale labels Sep 4, 2024
@jparcill
Copy link
Contributor

Hi! Taking a look at this. The in kind value for a donation is donation.value_per_itemizable right?

@cielf
Copy link
Collaborator Author

cielf commented Sep 15, 2024

That doesn't sound quite right -- I'll take a look. It might just be badly named.
(Edit. Oh. I see why it's named that. )
Yes. That's right.

@jparcill
Copy link
Contributor

Cool have a PR up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants