Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PACKS] item units for new requests should not be set initally. #4612

Open
2 tasks
cielf opened this issue Aug 25, 2024 · 2 comments
Open
2 tasks

[PACKS] item units for new requests should not be set initally. #4612

cielf opened this issue Aug 25, 2024 · 2 comments

Comments

@cielf
Copy link
Collaborator

cielf commented Aug 25, 2024

Summary

New request for packs was implemented with a default. We need it to have no default

Why

Reduction of partner error -- some partners will do one unit, some another, within the same bank.

Details

The custom units field for the request should not be defaulted -- it should start with a 'please select...' (althernatively we could do it as a non-selected radio button group). It must, however, be selected on save if the quantity for the corresponding item is not 0.

Criteria for completion

  • behaviour as described above
  • automated tests to demonstrated the behaviour.
@cielf cielf added this to the Request Units (Packs) milestone Aug 25, 2024
@isaiah3031
Copy link
Contributor

Hey @cielf, I'd like to work on this issue. Just to clarify, this is on the new distribution form right?

@awwaiid awwaiid self-assigned this Aug 30, 2024
@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Aug 30, 2024
@cielf
Copy link
Collaborator Author

cielf commented Aug 30, 2024

Hey @isaiah3031 -- Thank you for your interest! We're really close to getting the whole PACKS milestone done, and this is on the critical path, so I've asked @awwaiid (one of our senior staff) to take it on just for speed's sake. May I suggest #4343 as an alternative?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants