Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text on confirming audit that the audit must be finalized for it to take effect. #4633

Open
2 tasks
cielf opened this issue Sep 1, 2024 · 2 comments
Open
2 tasks
Assignees
Labels
Good First Issue Suitable for users that are newer or less experienced

Comments

@cielf
Copy link
Collaborator

cielf commented Sep 1, 2024

Summary

Add a confirmation message on "Confirm" in Audit that includes the information that the audit must be finalized before any changes will be made to the inventory.

Why?

Avoiding the banks doing distributions in between confirmation and finalization.

Details

Steps to the place this has to be:
login as [email protected]
Inventory
Inventory Audit
New Audit
Choose storage location and enter a quantity for at least one item
Click "Confirm Audit"
We currently have an "Are you sure?" confirmation pop-up there.

This should also have the text "Please note that this audit must also be finalized by someone with organization admin rights before changes to inventory will take place. We strongly recommend completing that step before doing any further actions that affect inventory."

Criteria for completion

  • message appears
  • test to confirm
@cielf cielf added the Good First Issue Suitable for users that are newer or less experienced label Sep 1, 2024
@tatheerf02
Copy link

Hi @cielf! Could I please take on this task? I'm new to open source, but familiar with Ruby :)

@cielf
Copy link
Collaborator Author

cielf commented Sep 6, 2024

That's why we have good first issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Suitable for users that are newer or less experienced
Projects
None yet
Development

No branches or pull requests

2 participants