From 954b386e8d82c84507801cb22bb0d06991a45592 Mon Sep 17 00:00:00 2001 From: Daniel Orner Date: Fri, 13 Sep 2024 15:49:57 -0400 Subject: [PATCH 1/2] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 2c0cc5b874..6b13062d5f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -8,6 +8,7 @@ - I have added tests that prove my fix is effective or that my feature works, - New and existing unit tests pass locally with my changes ("bundle exec rake"), - Title include "WIP" if work is in progress. +- I acknowledge that I will *not* force push my branch if any review activity has already happened. --> From b7d9e0d4a116bb9204cae8dfc0f33a39caddf379 Mon Sep 17 00:00:00 2001 From: Daniel Orner Date: Fri, 13 Sep 2024 16:16:33 -0400 Subject: [PATCH 2/2] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 6b13062d5f..d5cd5277e9 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -8,7 +8,7 @@ - I have added tests that prove my fix is effective or that my feature works, - New and existing unit tests pass locally with my changes ("bundle exec rake"), - Title include "WIP" if work is in progress. -- I acknowledge that I will *not* force push my branch if any review activity has already happened. +- I acknowledge that I will *not* force push my branch once reviews have started. -->