Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature ClassRef not supported with minor version: null, please use minor version: 41 or above #522

Closed
gregdymek opened this issue Jun 9, 2020 · 5 comments

Comments

@gregdymek
Copy link

on POST
http://sandbox-quickbooks.api.intuit.com:443/v3/company/XXX/item
it looks like we're not sending minor version on service item,
looking at the code we only append minorversion for url_for_query shouldn't we also send it in other methods?
it stopped working ~ a week ago

@ruckus
Copy link
Owner

ruckus commented Jun 10, 2020

Good call. For some reason I was under the impression the minorversion handling only applied to GET requests. But I now see that doesn't make much sense.

I have opened this PR with support for ensuring a minorversion query param is sent on all HTTP requests.

#518

If you have a chance to take a look at the PR that would be appreciated

@gregdymek
Copy link
Author

hey @ruckus, we are little blocked here, any chance you can release it soon?

@ruckus
Copy link
Owner

ruckus commented Jun 15, 2020

Hi @gregdymek - gotcha. Before I release the gem it would be great if you could test it. Are you in a position to give this branch a whirl:

https://github.com/ruckus/quickbooks-ruby/tree/global-minorversion

Thanks!

@gregdymek
Copy link
Author

hi @ruckus - so far everything is working for us

@ruckus
Copy link
Owner

ruckus commented Jun 16, 2020

@gregdymek great I have just released 1.0.11

3c68b68

@ruckus ruckus closed this as completed Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants