chore(release): pull main into develop post release v3.3.0 #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoumitaM
requested review from
ItsSudip,
shrouti1507,
sandeepdsvs,
koladilip,
mihir-4116 and
a team
as code owners
WalkthroughThe recent updates across various packages primarily focus on enhancing the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1668 +/- ##
===========================================
+ Coverage 53.89% 53.90% +0.01%
===========================================
Files 461 461
Lines 15588 15611 +23
Branches 3095 3102 +7
===========================================
+ Hits 8401 8415 +14
- Misses 5871 5890 +19
+ Partials 1316 1306 -10 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files ignored due to path filters (15)
package-lock.jsonis excluded by:!**/*.jsonpackage.jsonis excluded by:!**/*.jsonpackages/analytics-js-common/package.jsonis excluded by:!**/*.jsonpackages/analytics-js-common/project.jsonis excluded by:!**/*.jsonpackages/analytics-js-integrations/package.jsonis excluded by:!**/*.jsonpackages/analytics-js-integrations/project.jsonis excluded by:!**/*.jsonpackages/analytics-js-plugins/package.jsonis excluded by:!**/*.jsonpackages/analytics-js-plugins/project.jsonis excluded by:!**/*.jsonpackages/analytics-js/package.jsonis excluded by:!**/*.jsonpackages/analytics-js/project.jsonis excluded by:!**/*.jsonpackages/analytics-v1.1/package.jsonis excluded by:!**/*.jsonpackages/analytics-v1.1/project.jsonis excluded by:!**/*.jsonpackages/loading-scripts/package.jsonis excluded by:!**/*.jsonpackages/loading-scripts/project.jsonis excluded by:!**/*.jsonpackages/sanity-suite/package.jsonis excluded by:!**/*.json
Files selected for processing (14)
- packages/analytics-js-common/CHANGELOG.md (1 hunks)
- packages/analytics-js-common/CHANGELOG_LATEST.md (1 hunks)
- packages/analytics-js-integrations/CHANGELOG.md (1 hunks)
- packages/analytics-js-integrations/CHANGELOG_LATEST.md (1 hunks)
- packages/analytics-js-plugins/CHANGELOG.md (1 hunks)
- packages/analytics-js-plugins/CHANGELOG_LATEST.md (1 hunks)
- packages/analytics-js/CHANGELOG.md (1 hunks)
- packages/analytics-js/CHANGELOG_LATEST.md (1 hunks)
- packages/analytics-v1.1/CHANGELOG.md (1 hunks)
- packages/analytics-v1.1/CHANGELOG_LATEST.md (1 hunks)
- packages/loading-scripts/CHANGELOG.md (1 hunks)
- packages/loading-scripts/CHANGELOG_LATEST.md (1 hunks)
- packages/sanity-suite/CHANGELOG.md (1 hunks)
- sonar-project.properties (1 hunks)
Files skipped from review due to trivial changes (5)
- packages/analytics-js-integrations/CHANGELOG_LATEST.md
- packages/analytics-js-plugins/CHANGELOG.md
- packages/analytics-v1.1/CHANGELOG.md
- packages/sanity-suite/CHANGELOG.md
- sonar-project.properties
Additional comments: 10
packages/analytics-v1.1/CHANGELOG_LATEST.md (1)
- 1-10: LGTM! The changelog is clear and follows the conventional format, providing transparency and traceability for the changes.
packages/analytics-js-plugins/CHANGELOG_LATEST.md (1)
- 1-10: LGTM! The changelog is well-structured, providing clear information on dependency updates and bug fixes.
packages/loading-scripts/CHANGELOG_LATEST.md (1)
- 1-11: LGTM! The changelog provides a clear and structured overview of the updates, including dependency updates and bug fixes.
packages/analytics-js-common/CHANGELOG_LATEST.md (1)
- 1-12: LGTM! The changelog is comprehensive, detailing new features and bug fixes in a clear and structured manner.
packages/analytics-js/CHANGELOG_LATEST.md (1)
- 1-13: LGTM! The changelog provides a clear and structured overview of the updates, including dependency updates and bug fixes.
packages/loading-scripts/CHANGELOG.md (1)
- 5-15: LGTM! The comprehensive changelog provides a clear historical view of the changes across versions, maintaining consistency and traceability.
packages/analytics-js-common/CHANGELOG.md (1)
- 10-10: Consider revising "apiobject" and "apioptions" to ensure they are correctly spelled or formatted according to your project's naming conventions. If these are specific technical terms within your project, consider using backticks (
apiobjectandapioptions) for clarity.packages/analytics-js-integrations/CHANGELOG.md (1)
- 5-9: The documentation of the dependency update for
@rudderstack/analytics-js-commonto version 3.0.1 in version 3.0.2 is clear and accurate.packages/analytics-js/CHANGELOG.md (2)
- 5-10: The version update and dependency updates are correctly documented.
- 12-16: The bug fixes section is well-documented, providing clear traceability to the issues and commits.
|
|
||
| ### Bug Fixes | ||
|
|
||
| * optimize localstorage transactions ([#1651](https://github.com/rudderlabs/rudder-sdk-js/issues/1651)) ([1289217](https://github.com/rudderlabs/rudder-sdk-js/commit/12892176578dd3628fded2311ea2548e3ff5802c)) |
There was a problem hiding this comment.
The term "localstorage" might be more accurately written as "localStorage" to reflect the correct API name in web development. Consider updating this for clarity and consistency with web standards.
- * optimize localstorage transactions ([#1651](https://github.com/rudderlabs/rudder-sdk-js/issues/1651)) ([1289217](https://github.com/rudderlabs/rudder-sdk-js/commit/12892176578dd3628fded2311ea2548e3ff5802c))
+ * optimize localStorage transactions ([#1651](https://github.com/rudderlabs/rudder-sdk-js/issues/1651)) ([1289217](https://github.com/rudderlabs/rudder-sdk-js/commit/12892176578dd3628fded2311ea2548e3ff5802c))Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| * optimize localstorage transactions ([#1651](https://github.com/rudderlabs/rudder-sdk-js/issues/1651)) ([1289217](https://github.com/rudderlabs/rudder-sdk-js/commit/12892176578dd3628fded2311ea2548e3ff5802c)) | |
| * optimize localStorage transactions ([#1651](https://github.com/rudderlabs/rudder-sdk-js/issues/1651)) ([1289217](https://github.com/rudderlabs/rudder-sdk-js/commit/12892176578dd3628fded2311ea2548e3ff5802c)) |
size-limit report 📦
|
saikumarrs
previously approved these changes
Mar 22, 2024
…#1669) fix: add backward compatibility for storage api
saikumarrs
changed the title
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files ignored due to path filters (9)
package-lock.jsonis excluded by:!**/*.jsonpackage.jsonis excluded by:!**/*.jsonpackages/analytics-js-plugins/package.jsonis excluded by:!**/*.jsonpackages/analytics-js-plugins/project.jsonis excluded by:!**/*.jsonpackages/analytics-js/package.jsonis excluded by:!**/*.jsonpackages/analytics-js/project.jsonis excluded by:!**/*.jsonpackages/loading-scripts/package.jsonis excluded by:!**/*.jsonpackages/loading-scripts/project.jsonis excluded by:!**/*.jsonpackages/sanity-suite/package.jsonis excluded by:!**/*.json
Files selected for processing (9)
- packages/analytics-js-plugins/CHANGELOG.md (1 hunks)
- packages/analytics-js-plugins/CHANGELOG_LATEST.md (1 hunks)
- packages/analytics-js-plugins/src/utilities/retryQueue/RetryQueue.ts (2 hunks)
- packages/analytics-js/CHANGELOG.md (1 hunks)
- packages/analytics-js/CHANGELOG_LATEST.md (1 hunks)
- packages/loading-scripts/CHANGELOG.md (1 hunks)
- packages/loading-scripts/CHANGELOG_LATEST.md (1 hunks)
- packages/sanity-suite/CHANGELOG.md (1 hunks)
- sonar-project.properties (1 hunks)
Files skipped from review as they are similar to previous changes (5)
- packages/analytics-js/CHANGELOG_LATEST.md
- packages/loading-scripts/CHANGELOG.md
- packages/loading-scripts/CHANGELOG_LATEST.md
- packages/sanity-suite/CHANGELOG.md
- sonar-project.properties
Additional comments: 7
packages/analytics-js-plugins/CHANGELOG_LATEST.md (1)
- 1-7: The change log update for version
3.0.3ofanalytics-js-pluginsis clear and adheres to standard practices, detailing the bug fixes for backward compatibility with the storage API effectively.packages/analytics-js-plugins/CHANGELOG.md (1)
- 5-11: The changelog entry for version 3.0.3 of
@rudderstack/analytics-js-pluginsclearly documents the addition of backward compatibility for the storage API. This is a crucial update for users relying on previous storage API versions. It's important to ensure that all relevant details about such changes are captured in the changelog to aid developers in understanding the impact of the update on their implementations.packages/analytics-js-plugins/src/utilities/retryQueue/RetryQueue.ts (2)
- 8-8: The import statement correctly includes
isDefined,isFunction, andisNullOrUndefinedfrom@rudderstack/analytics-js-common/utilities/checks. This aligns with the summary stating thatisDefinedandisNullOrUndefinedfunctions are replaced withisDefined,isFunction, andisNullOrUndefined.- 708-721: The addition of a check for the existence of the
keysfunction in the storage engine (lines 708-721) is a good practice for ensuring backward compatibility. This change allows theRetryQueueclass to work with different versions of the storage engine that may or may not support thekeysmethod. However, it's important to ensure that thestorageEngineobject always has alengthproperty and akeymethod when thekeysmethod is not available. This assumption should be verified if not already known to be true.packages/analytics-js/CHANGELOG.md (3)
- 5-5: The markdown link for version
3.0.3seems to be formatted correctly, but static analysis hinted at possible unpaired symbols. This appears to be a false positive, as the markdown syntax for links is correct throughout the document. No action is required here.- 5-5: Ensure the correctness of GitHub comparison links for each version. While the format looks correct, it's important to manually verify that these links lead to the intended comparisons between versions.
- 7-7: The descriptions for features and bug fixes are clear and concise, providing valuable context for users. Including links to relevant GitHub issues and commits is a good practice for transparency.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Please include a summary of the change along with the relevant motivation and context.
Linear task (optional)
Linear task link
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security
Summary by CodeRabbit